Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99853002: Added the reset prompt memento as a tracked preference. (Closed)

Created:
7 years ago by engedy
Modified:
7 years ago
CC:
Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Added the reset prompt memento as a tracked preference. BUG=298036 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238383

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed formatting nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/prefs/pref_metrics_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
engedy
@Gab, @Alexei: please take a look at the respective files.
7 years ago (2013-12-02 18:59:24 UTC) #1
Alexei Svitkine (slow)
lgtm
7 years ago (2013-12-02 19:34:50 UTC) #2
gab
lgtm w/ nit https://codereview.chromium.org/99853002/diff/1/chrome/browser/prefs/pref_metrics_service.cc File chrome/browser/prefs/pref_metrics_service.cc (right): https://codereview.chromium.org/99853002/diff/1/chrome/browser/prefs/pref_metrics_service.cc#newcode70 chrome/browser/prefs/pref_metrics_service.cc:70: prefs::kProfileResetPromptMemento nit: add trailing comma
7 years ago (2013-12-02 19:41:22 UTC) #3
engedy
https://codereview.chromium.org/99853002/diff/1/chrome/browser/prefs/pref_metrics_service.cc File chrome/browser/prefs/pref_metrics_service.cc (right): https://codereview.chromium.org/99853002/diff/1/chrome/browser/prefs/pref_metrics_service.cc#newcode70 chrome/browser/prefs/pref_metrics_service.cc:70: prefs::kProfileResetPromptMemento On 2013/12/02 19:41:23, gab wrote: > nit: add ...
7 years ago (2013-12-03 09:09:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/engedy@chromium.org/99853002/20001
7 years ago (2013-12-03 09:34:07 UTC) #5
engedy
@Dominic: please review for ONWER's approval.
7 years ago (2013-12-03 10:27:17 UTC) #6
battre
lgtm
7 years ago (2013-12-03 10:31:36 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-03 13:06:33 UTC) #8
Message was sent while issue was closed. 
Change committed as 238383

Powered by Google App Engine
This is Rietveld 408576698