Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

Issue 998513002: Revert of Remove OneClickSigninHelper since it is no longer used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ocl
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ebae62fa0a68c8ab6718e420d3523d7acc1ecdeb
--- /dev/null
+++ b/chrome/browser/ui/sync/one_click_signin_helper_unittest.cc
@@ -0,0 +1,986 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/prefs/pref_service.h"
+#include "base/prefs/scoped_user_pref_update.h"
+#include "base/run_loop.h"
+#include "base/strings/utf_string_conversions.h"
+#include "base/values.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/content_settings/cookie_settings.h"
+#include "chrome/browser/custom_handlers/protocol_handler_registry.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_info_cache.h"
+#include "chrome/browser/profiles/profile_io_data.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/signin/chrome_signin_client.h"
+#include "chrome/browser/signin/chrome_signin_client_factory.h"
+#include "chrome/browser/signin/fake_profile_oauth2_token_service.h"
+#include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
+#include "chrome/browser/signin/fake_signin_manager.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
+#include "chrome/browser/signin/signin_names_io_thread.h"
+#include "chrome/browser/signin/signin_promo.h"
+#include "chrome/browser/sync/profile_sync_components_factory_mock.h"
+#include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/browser/sync/test_profile_sync_service.h"
+#include "chrome/browser/ui/sync/one_click_signin_helper.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/grit/chromium_strings.h"
+#include "chrome/grit/generated_resources.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_pref_service_syncable.h"
+#include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/testing_profile_manager.h"
+#include "components/autofill/core/common/password_form.h"
+#include "components/signin/core/browser/profile_oauth2_token_service.h"
+#include "components/signin/core/browser/signin_manager.h"
+#include "components/sync_driver/pref_names.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/navigation_details.h"
+#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_delegate.h"
+#include "content/public/common/frame_navigate_params.h"
+#include "content/public/common/url_constants.h"
+#include "content/public/test/mock_render_process_host.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
+
+using ::testing::_;
+using ::testing::AtLeast;
+using ::testing::Return;
+
+namespace {
+
+// Used to confirm OneClickSigninHelper does not trigger redirect when there is
+// a pending navigation.
+class MockWebContentsDelegate : public content::WebContentsDelegate {
+ public:
+ MOCK_METHOD2(OpenURLFromTab,
+ content::WebContents*(content::WebContents* source,
+ const content::OpenURLParams& params));
+};
+
+class SigninManagerMock : public FakeSigninManager {
+ public:
+ explicit SigninManagerMock(Profile* profile) : FakeSigninManager(profile) {
+ Initialize(NULL);
+ }
+ MOCK_CONST_METHOD1(IsAllowedUsername, bool(const std::string& username));
+};
+
+static KeyedService* BuildSigninManagerMock(content::BrowserContext* profile) {
+ return new SigninManagerMock(static_cast<Profile*>(profile));
+}
+
+class TestProfileIOData : public ProfileIOData {
+ public:
+ TestProfileIOData(Profile::ProfileType profile_type,
+ PrefService* pref_service, PrefService* local_state,
+ CookieSettings* cookie_settings)
+ : ProfileIOData(profile_type) {
+ // Initialize the IO members required for these tests, but keep them on
+ // this thread since we don't use a background thread here.
+ google_services_username()->Init(prefs::kGoogleServicesUsername,
+ pref_service);
+ reverse_autologin_enabled()->Init(prefs::kReverseAutologinEnabled,
+ pref_service);
+ one_click_signin_rejected_email_list()->Init(
+ prefs::kReverseAutologinRejectedEmailList, pref_service);
+
+ google_services_username_pattern()->Init(
+ prefs::kGoogleServicesUsernamePattern, local_state);
+
+ sync_disabled()->Init(sync_driver::prefs::kSyncManaged, pref_service);
+
+ signin_allowed()->Init(prefs::kSigninAllowed, pref_service);
+
+ set_signin_names_for_testing(new SigninNamesOnIOThread());
+ SetCookieSettingsForTesting(cookie_settings);
+ }
+
+ ~TestProfileIOData() override {
+ signin_names()->ReleaseResourcesOnUIThread();
+ }
+
+ // ProfileIOData overrides:
+ void InitializeInternal(
+ scoped_ptr<ChromeNetworkDelegate> chrome_network_delegate,
+ ProfileParams* profile_params,
+ content::ProtocolHandlerMap* protocol_handlers,
+ content::URLRequestInterceptorScopedVector
+ request_interceptors) const override {
+ NOTREACHED();
+ }
+ void InitializeExtensionsRequestContext(
+ ProfileParams* profile_params) const override {
+ NOTREACHED();
+ }
+ net::URLRequestContext* InitializeAppRequestContext(
+ net::URLRequestContext* main_context,
+ const StoragePartitionDescriptor& details,
+ scoped_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
+ protocol_handler_interceptor,
+ content::ProtocolHandlerMap* protocol_handlers,
+ content::URLRequestInterceptorScopedVector request_interceptors)
+ const override {
+ NOTREACHED();
+ return NULL;
+ }
+ net::URLRequestContext* InitializeMediaRequestContext(
+ net::URLRequestContext* original_context,
+ const StoragePartitionDescriptor& details) const override {
+ NOTREACHED();
+ return NULL;
+ }
+ net::URLRequestContext* AcquireMediaRequestContext() const override {
+ NOTREACHED();
+ return NULL;
+ }
+ net::URLRequestContext* AcquireIsolatedAppRequestContext(
+ net::URLRequestContext* main_context,
+ const StoragePartitionDescriptor& partition_descriptor,
+ scoped_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
+ protocol_handler_interceptor,
+ content::ProtocolHandlerMap* protocol_handlers,
+ content::URLRequestInterceptorScopedVector request_interceptors)
+ const override {
+ NOTREACHED();
+ return NULL;
+ }
+ net::URLRequestContext* AcquireIsolatedMediaRequestContext(
+ net::URLRequestContext* app_context,
+ const StoragePartitionDescriptor& partition_descriptor) const override {
+ NOTREACHED();
+ return NULL;
+ }
+};
+
+class TestURLRequest : public base::SupportsUserData {
+ public:
+ TestURLRequest() {}
+ ~TestURLRequest() override {}
+};
+
+class OneClickTestProfileSyncService : public TestProfileSyncService {
+ public:
+ ~OneClickTestProfileSyncService() override {}
+
+ // Helper routine to be used in conjunction with
+ // BrowserContextKeyedServiceFactory::SetTestingFactory().
+ static KeyedService* Build(content::BrowserContext* profile) {
+ return new OneClickTestProfileSyncService(static_cast<Profile*>(profile));
+ }
+
+ // Need to control this for certain tests.
+ bool FirstSetupInProgress() const override {
+ return first_setup_in_progress_;
+ }
+
+ bool SyncActive() const override { return sync_active_; }
+
+ // Controls return value of FirstSetupInProgress. Because some bits
+ // of UI depend on that value, it's useful to control it separately
+ // from the internal work and components that are triggered (such as
+ // ReconfigureDataTypeManager) to facilitate unit tests.
+ void set_first_setup_in_progress(bool in_progress) {
+ first_setup_in_progress_ = in_progress;
+ }
+
+ void set_sync_active(bool active) {
+ sync_active_ = active;
+ }
+
+ private:
+ explicit OneClickTestProfileSyncService(Profile* profile)
+ : TestProfileSyncService(
+ scoped_ptr<ProfileSyncComponentsFactory>(
+ new ProfileSyncComponentsFactoryMock()),
+ profile,
+ SigninManagerFactory::GetForProfile(profile),
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile),
+ browser_sync::MANUAL_START),
+ first_setup_in_progress_(false),
+ sync_active_(false) {}
+
+ bool first_setup_in_progress_;
+ bool sync_active_;
+};
+
+} // namespace
+
+class OneClickSigninHelperTest : public ChromeRenderViewHostTestHarness {
+ public:
+ OneClickSigninHelperTest();
+
+ void SetUp() override;
+ void TearDown() override;
+
+ // Sets up the sign-in manager for tests. If |username| is
+ // is not empty, the profile of the mock WebContents will be connected to
+ // the given account.
+ void SetUpSigninManager(const std::string& username);
+
+ // Set the ID of the signin process that the test will assume to be the
+ // only process allowed to sign the user in to Chrome.
+ void SetTrustedSigninProcessID(int id);
+
+ void AddEmailToOneClickRejectedList(const std::string& email);
+ void EnableOneClick(bool enable);
+ void AllowSigninCookies(bool enable);
+ void SetAllowedUsernamePattern(const std::string& pattern);
+ void SubmitGAIAPassword(OneClickSigninHelper* helper);
+
+ SigninManagerMock* signin_manager_;
+ FakeProfileOAuth2TokenService* fake_oauth2_token_service_;
+
+ protected:
+ GoogleServiceAuthError no_error_;
+
+ private:
+ // ChromeRenderViewHostTestHarness overrides:
+ content::BrowserContext* CreateBrowserContext() override;
+
+ // The ID of the signin process the test will assume to be trusted.
+ // By default, set to the test RenderProcessHost's process ID, but
+ // overridden by SetTrustedSigninProcessID.
+ int trusted_signin_process_id_;
+
+ DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelperTest);
+};
+
+OneClickSigninHelperTest::OneClickSigninHelperTest()
+ : signin_manager_(NULL),
+ fake_oauth2_token_service_(NULL),
+ no_error_(GoogleServiceAuthError::NONE),
+ trusted_signin_process_id_(-1) {
+}
+
+void OneClickSigninHelperTest::SetUp() {
+ signin::ForceWebBasedSigninFlowForTesting(true);
+ content::RenderViewHostTestHarness::SetUp();
+ SetTrustedSigninProcessID(process()->GetID());
+}
+
+void OneClickSigninHelperTest::TearDown() {
+ signin::ForceWebBasedSigninFlowForTesting(false);
+ content::RenderViewHostTestHarness::TearDown();
+}
+
+void OneClickSigninHelperTest::SetTrustedSigninProcessID(int id) {
+ trusted_signin_process_id_ = id;
+}
+
+void OneClickSigninHelperTest::SetUpSigninManager(const std::string& username) {
+ SigninClient* signin_client =
+ ChromeSigninClientFactory::GetForProfile(profile());
+ if (signin_client)
+ signin_client->SetSigninProcess(trusted_signin_process_id_);
+
+ signin_manager_ = static_cast<SigninManagerMock*>(
+ SigninManagerFactory::GetForProfile(profile()));
+ if (!username.empty()) {
+ ASSERT_TRUE(signin_manager_);
+ signin_manager_->SetAuthenticatedUsername(username);
+ }
+}
+
+void OneClickSigninHelperTest::EnableOneClick(bool enable) {
+ PrefService* pref_service = profile()->GetPrefs();
+ pref_service->SetBoolean(prefs::kReverseAutologinEnabled, enable);
+}
+
+void OneClickSigninHelperTest::AddEmailToOneClickRejectedList(
+ const std::string& email) {
+ PrefService* pref_service = profile()->GetPrefs();
+ ListPrefUpdate updater(pref_service,
+ prefs::kReverseAutologinRejectedEmailList);
+ updater->AppendIfNotPresent(new base::StringValue(email));
+}
+
+void OneClickSigninHelperTest::AllowSigninCookies(bool enable) {
+ CookieSettings* cookie_settings =
+ CookieSettings::Factory::GetForProfile(profile()).get();
+ cookie_settings->SetDefaultCookieSetting(enable ? CONTENT_SETTING_ALLOW
+ : CONTENT_SETTING_BLOCK);
+}
+
+void OneClickSigninHelperTest::SetAllowedUsernamePattern(
+ const std::string& pattern) {
+ PrefService* local_state = g_browser_process->local_state();
+ local_state->SetString(prefs::kGoogleServicesUsernamePattern, pattern);
+}
+
+void OneClickSigninHelperTest::SubmitGAIAPassword(
+ OneClickSigninHelper* helper) {
+ autofill::PasswordForm password_form;
+ password_form.origin = GURL("https://accounts.google.com");
+ password_form.signon_realm = "https://accounts.google.com";
+ password_form.password_value = base::UTF8ToUTF16("password");
+ helper->PasswordSubmitted(password_form);
+}
+
+content::BrowserContext* OneClickSigninHelperTest::CreateBrowserContext() {
+ TestingProfile::Builder builder;
+ builder.AddTestingFactory(ProfileOAuth2TokenServiceFactory::GetInstance(),
+ BuildFakeProfileOAuth2TokenService);
+ builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
+ BuildSigninManagerMock);
+ scoped_ptr<TestingProfile> profile = builder.Build();
+
+ fake_oauth2_token_service_ =
+ static_cast<FakeProfileOAuth2TokenService*>(
+ ProfileOAuth2TokenServiceFactory::GetForProfile(profile.get()));
+
+ return profile.release();
+}
+
+class OneClickSigninHelperIOTest : public OneClickSigninHelperTest {
+ public:
+ OneClickSigninHelperIOTest();
+
+ void SetUp() override;
+
+ TestProfileIOData* CreateTestProfileIOData(Profile::ProfileType profile_type);
+
+ protected:
+ TestingProfileManager testing_profile_manager_;
+ TestURLRequest request_;
+ const GURL valid_gaia_url_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(OneClickSigninHelperIOTest);
+};
+
+OneClickSigninHelperIOTest::OneClickSigninHelperIOTest()
+ : testing_profile_manager_(
+ TestingBrowserProcess::GetGlobal()),
+ valid_gaia_url_("https://accounts.google.com/") {
+}
+
+void OneClickSigninHelperIOTest::SetUp() {
+ OneClickSigninHelperTest::SetUp();
+ ASSERT_TRUE(testing_profile_manager_.SetUp());
+}
+
+TestProfileIOData* OneClickSigninHelperIOTest::CreateTestProfileIOData(
+ Profile::ProfileType profile_type) {
+ PrefService* pref_service = profile()->GetPrefs();
+ PrefService* local_state = g_browser_process->local_state();
+ CookieSettings* cookie_settings =
+ CookieSettings::Factory::GetForProfile(profile()).get();
+ TestProfileIOData* io_data = new TestProfileIOData(
+ profile_type, pref_service, local_state, cookie_settings);
+ io_data->set_reverse_autologin_pending_email("user@gmail.com");
+ return io_data;
+}
+
+class OneClickSigninHelperIncognitoTest : public OneClickSigninHelperTest {
+ protected:
+ // content::RenderViewHostTestHarness.
+ content::BrowserContext* CreateBrowserContext() override;
+};
+
+content::BrowserContext*
+OneClickSigninHelperIncognitoTest::CreateBrowserContext() {
+ // Simulate an incognito profile to run this test. RenderViewHostTestHarness
+ // takes ownership of the return value, so it can't be a "proper" incognito
+ // profile, since they are owned by their parent, non-incognito profile.
+ scoped_ptr<TestingProfile> profile = TestingProfile::Builder().Build();
+ profile->ForceIncognito(true);
+ return profile.release();
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferNoContents) {
+ std::string error_message;
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ NULL, OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ NULL, OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ NULL,
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ &error_message));
+ EXPECT_EQ("", error_message);
+}
+
+TEST_F(OneClickSigninHelperTest, CanOffer) {
+ SetUpSigninManager(std::string());
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(true));
+
+ EnableOneClick(true);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", NULL));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", NULL));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ NULL));
+
+ EnableOneClick(false);
+
+ std::string error_message;
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", &error_message));
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ &error_message));
+ EXPECT_EQ("", error_message);
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferFirstSetup) {
+ SetUpSigninManager(std::string());
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(true));
+
+ // Invoke OneClickTestProfileSyncService factory function and grab result.
+ OneClickTestProfileSyncService* sync =
+ static_cast<OneClickTestProfileSyncService*>(
+ ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+ profile(), OneClickTestProfileSyncService::Build));
+ sync->set_sync_active(false);
+ sync->Initialize();
+ sync->set_sync_active(true);
+ sync->set_first_setup_in_progress(true);
+
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "foo@gmail.com", NULL));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "foo@gmail.com", NULL));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ NULL));
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferProfileConnected) {
+ SetUpSigninManager("foo@gmail.com");
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(true));
+
+ std::string error_message;
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "foo@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "foo", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ(l10n_util::GetStringFUTF8(IDS_SYNC_WRONG_EMAIL,
+ base::UTF8ToUTF16("foo@gmail.com")),
+ error_message);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "foo@gmail.com", &error_message));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "foo", &error_message));
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ(l10n_util::GetStringFUTF8(IDS_SYNC_WRONG_EMAIL,
+ base::UTF8ToUTF16("foo@gmail.com")),
+ error_message);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ &error_message));
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferUsernameNotAllowed) {
+ SetUpSigninManager(std::string());
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(false));
+
+ std::string error_message;
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "foo@gmail.com", &error_message));
+ EXPECT_EQ(l10n_util::GetStringUTF8(IDS_SYNC_LOGIN_NAME_PROHIBITED),
+ error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "foo@gmail.com", &error_message));
+ EXPECT_EQ(l10n_util::GetStringUTF8(IDS_SYNC_LOGIN_NAME_PROHIBITED),
+ error_message);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ &error_message));
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferWithRejectedEmail) {
+ SetUpSigninManager(std::string());
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(true));
+
+ AddEmailToOneClickRejectedList("foo@gmail.com");
+ AddEmailToOneClickRejectedList("user@gmail.com");
+
+ std::string error_message;
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "foo@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "foo@gmail.com", &error_message));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", &error_message));
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "john@gmail.com", &error_message));
+}
+
+TEST_F(OneClickSigninHelperIncognitoTest, CanOfferIncognito) {
+ SetUpSigninManager(std::string());
+
+ std::string error_message;
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ &error_message));
+ EXPECT_EQ("", error_message);
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferNoSigninCookies) {
+ SetUpSigninManager(std::string());
+ AllowSigninCookies(false);
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(true));
+
+ std::string error_message;
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", &error_message));
+ EXPECT_EQ("", error_message);
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(),
+ OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
+ std::string(),
+ &error_message));
+ EXPECT_EQ("", error_message);
+}
+
+TEST_F(OneClickSigninHelperTest, CanOfferDisabledByPolicy) {
+ SetUpSigninManager(std::string());
+
+ EXPECT_CALL(*signin_manager_, IsAllowedUsername(_)).
+ WillRepeatedly(Return(true));
+
+ EnableOneClick(true);
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", NULL));
+
+ // Simulate a policy disabling signin by writing kSigninAllowed directly.
+ profile()->GetTestingPrefService()->SetManagedPref(
+ prefs::kSigninAllowed, new base::FundamentalValue(false));
+
+ EXPECT_FALSE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", NULL));
+
+ // Reset the preference value to true.
+ profile()->GetTestingPrefService()->SetManagedPref(
+ prefs::kSigninAllowed, new base::FundamentalValue(true));
+
+ // Simulate a policy disabling sync by writing kSyncManaged directly.
+ profile()->GetTestingPrefService()->SetManagedPref(
+ sync_driver::prefs::kSyncManaged, new base::FundamentalValue(true));
+
+ // Should still offer even if sync is disabled by policy.
+ EXPECT_TRUE(OneClickSigninHelper::CanOffer(
+ web_contents(), OneClickSigninHelper::CAN_OFFER_FOR_ALL,
+ "user@gmail.com", NULL));
+}
+
+// Should not crash if a helper instance is not associated with an incognito
+// web contents.
+TEST_F(OneClickSigninHelperIncognitoTest, ShowInfoBarUIThreadIncognito) {
+ SetUpSigninManager(std::string());
+ OneClickSigninHelper* helper =
+ OneClickSigninHelper::FromWebContents(web_contents());
+ EXPECT_EQ(NULL, helper);
+
+ OneClickSigninHelper::ShowInfoBarUIThread(
+ "session_index", "email", OneClickSigninHelper::AUTO_ACCEPT_ACCEPTED,
+ signin_metrics::SOURCE_UNKNOWN, GURL(), process()->GetID(),
+ rvh()->GetRoutingID());
+}
+
+// Checks that the state of OneClickSigninHelper is cleaned when there is a
+// navigation away from the sign in flow that is not triggered by the
+// web contents.
+TEST_F(OneClickSigninHelperTest, CleanTransientStateOnNavigate) {
+ content::WebContents* contents = web_contents();
+
+ OneClickSigninHelper::CreateForWebContents(contents);
+ OneClickSigninHelper* helper =
+ OneClickSigninHelper::FromWebContents(contents);
+ helper->SetDoNotClearPendingEmailForTesting();
+ helper->auto_accept_ = OneClickSigninHelper::AUTO_ACCEPT_EXPLICIT;
+
+ content::LoadCommittedDetails details;
+ content::FrameNavigateParams params;
+ params.url = GURL("http://crbug.com");
+ params.transition = ui::PAGE_TRANSITION_TYPED;
+ helper->DidNavigateMainFrame(details, params);
+
+ EXPECT_EQ(OneClickSigninHelper::AUTO_ACCEPT_NONE, helper->auto_accept_);
+}
+
+TEST_F(OneClickSigninHelperTest, NoRedirectToNTPWithPendingEntry) {
+ content::NavigationController& controller = web_contents()->GetController();
+ EXPECT_FALSE(controller.GetPendingEntry());
+
+ const GURL fooWebUIURL("chrome://foo");
+ controller.LoadURL(fooWebUIURL, content::Referrer(),
+ ui::PAGE_TRANSITION_TYPED, std::string());
+ EXPECT_EQ(fooWebUIURL, controller.GetPendingEntry()->GetURL());
+
+ MockWebContentsDelegate delegate;
+ EXPECT_CALL(delegate, OpenURLFromTab(_, _)).Times(0);
+ web_contents()->SetDelegate(&delegate);
+ OneClickSigninHelper::RedirectToNtpOrAppsPage(
+ web_contents(), signin_metrics::SOURCE_UNKNOWN);
+
+ EXPECT_EQ(fooWebUIURL, controller.GetPendingEntry()->GetURL());
+}
+
+// I/O thread tests
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThread) {
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::CAN_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadIncognito) {
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::INCOGNITO_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadNoIOData) {
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, NULL));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadBadURL) {
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(
+ OneClickSigninHelper::IGNORE_REQUEST,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ GURL("https://foo.com/"), &request_, io_data.get()));
+ EXPECT_EQ(OneClickSigninHelper::IGNORE_REQUEST,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ GURL("http://accounts.google.com/"),
+ &request_,
+ io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadDisabled) {
+ EnableOneClick(false);
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadSignedIn) {
+ PrefService* pref_service = profile()->GetPrefs();
+ pref_service->SetString(prefs::kGoogleServicesUsername, "user@gmail.com");
+
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadEmailNotAllowed) {
+ SetAllowedUsernamePattern("*@example.com");
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadEmailAlreadyUsed) {
+ ProfileInfoCache* cache = testing_profile_manager_.profile_info_cache();
+ const base::FilePath& user_data_dir = cache->GetUserDataDir();
+ cache->AddProfileToCache(user_data_dir.Append(FILE_PATH_LITERAL("user")),
+ base::UTF8ToUTF16("user"),
+ base::UTF8ToUTF16("user@gmail.com"), 0,
+ std::string());
+
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadWithRejectedEmail) {
+ AddEmailToOneClickRejectedList("user@gmail.com");
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadNoSigninCookies) {
+ AllowSigninCookies(false);
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+TEST_F(OneClickSigninHelperIOTest, CanOfferOnIOThreadDisabledByPolicy) {
+ scoped_ptr<TestProfileIOData> io_data(
+ CreateTestProfileIOData(Profile::REGULAR_PROFILE));
+ EXPECT_EQ(OneClickSigninHelper::CAN_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+
+ // Simulate a policy disabling signin by writing kSigninAllowed directly.
+ // We should not offer to sign in the browser.
+ profile()->GetTestingPrefService()->SetManagedPref(
+ prefs::kSigninAllowed, new base::FundamentalValue(false));
+ EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+
+ // Reset the preference.
+ profile()->GetTestingPrefService()->SetManagedPref(
+ prefs::kSigninAllowed, new base::FundamentalValue(true));
+
+ // Simulate a policy disabling sync by writing kSyncManaged directly.
+ // We should still offer to sign in the browser.
+ profile()->GetTestingPrefService()->SetManagedPref(
+ sync_driver::prefs::kSyncManaged, new base::FundamentalValue(true));
+ EXPECT_EQ(OneClickSigninHelper::CAN_OFFER,
+ OneClickSigninHelper::CanOfferOnIOThreadImpl(
+ valid_gaia_url_, &request_, io_data.get()));
+}
+
+
+class MockStarterWrapper
+ : public testing::StrictMock<OneClickSigninHelper::SyncStarterWrapper> {
+ public:
+ MockStarterWrapper(
+ const OneClickSigninHelper::StartSyncArgs& args,
+ OneClickSigninSyncStarter::StartSyncMode start_mode);
+
+ MOCK_METHOD1(DisplayErrorBubble, void(const std::string& error_message));
+ MOCK_METHOD0(StartSigninOAuthHelper, void());
+ MOCK_METHOD2(StartOneClickSigninSyncStarter,
+ void(const std::string& email,
+ const std::string& refresh_token));
+};
+
+MockStarterWrapper::MockStarterWrapper(
+ const OneClickSigninHelper::StartSyncArgs& args,
+ OneClickSigninSyncStarter::StartSyncMode start_mode)
+ : testing::StrictMock<OneClickSigninHelper::SyncStarterWrapper>(
+ args, start_mode) {
+}
+
+class OneClickSyncStarterWrapperTest : public testing::Test {
+ public:
+ void SetUp() override {
+ TestingProfile::Builder builder;
+ profile_ = builder.Build();
+ }
+
+ void TearDown() override {
+ // Let the SyncStarterWrapper delete itself.
+ base::RunLoop().RunUntilIdle();
+ }
+
+ void SetCookie(const std::string& value) {
+ // Set a valid LSID cookie in the test cookie store.
+ scoped_refptr<net::CookieMonster> cookie_monster =
+ profile()->GetCookieMonster();
+ net::CookieOptions options;
+ options.set_include_httponly();
+ cookie_monster->SetCookieWithOptionsAsync(
+ GURL("https://accounts.google.com"),
+ value, options,
+ net::CookieMonster::SetCookiesCallback());
+ }
+
+ void SimulateRefreshTokenFetched(
+ SigninOAuthHelper::Consumer* consumer,
+ const std::string& email,
+ const std::string& display_email,
+ const std::string& refresh_token) {
+ consumer->OnSigninOAuthInformationAvailable(
+ email, display_email, refresh_token);
+ }
+
+ TestingProfile* profile() { return profile_.get(); }
+
+ private:
+ content::TestBrowserThreadBundle thread_bundle_;
+ scoped_ptr<TestingProfile> profile_;
+};
+
+TEST_F(OneClickSyncStarterWrapperTest, SignInWithRefreshToken) {
+ OneClickSigninHelper::StartSyncArgs args;
+ args.email = "foo@gmail.com";
+ args.password = "password";
+ args.refresh_token = "refresh_token";
+ MockStarterWrapper* wrapper = new MockStarterWrapper(
+ args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
+
+ EXPECT_CALL(*wrapper,
+ StartOneClickSigninSyncStarter("foo@gmail.com",
+ "refresh_token"));
+ wrapper->Start();
+}
+
+TEST_F(OneClickSyncStarterWrapperTest, SignInWithPasswordNoRefreshToken) {
+ OneClickSigninHelper::StartSyncArgs args;
+ args.email = "foo@gmail.com";
+ args.password = "password";
+ MockStarterWrapper* wrapper = new MockStarterWrapper(
+ args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
+
+ EXPECT_CALL(*wrapper, StartSigninOAuthHelper());
+ EXPECT_CALL(*wrapper,
+ StartOneClickSigninSyncStarter("foo@gmail.com",
+ "refresh_token"));
+ wrapper->Start();
+ SimulateRefreshTokenFetched(wrapper, "foo@gmail.com", "foo@gmail.com",
+ "refresh_token");
+}
+
+TEST_F(OneClickSyncStarterWrapperTest, SignInWithWrongEmail) {
+ OneClickSigninHelper::StartSyncArgs args;
+ args.email = "foo@gmail.com";
+ args.password = "password";
+ MockStarterWrapper* wrapper = new MockStarterWrapper(
+ args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
+
+ EXPECT_CALL(*wrapper, StartSigninOAuthHelper());
+ EXPECT_CALL(*wrapper, DisplayErrorBubble(_));
+ wrapper->Start();
+ SimulateRefreshTokenFetched(wrapper, "bar@gmail.com", "bar@gmail.com",
+ "refresh_token");
+}
+
+TEST_F(OneClickSyncStarterWrapperTest, SignInWithEmptyPasswordValidCookie) {
+ OneClickSigninHelper::StartSyncArgs args;
+ args.email = "foo@gmail.com";
+ args.profile = profile();
+ MockStarterWrapper* wrapper = new MockStarterWrapper(
+ args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
+ SetCookie("LSID=1234; secure; httponly");
+
+ EXPECT_CALL(*wrapper, StartSigninOAuthHelper());
+ EXPECT_CALL(*wrapper,
+ StartOneClickSigninSyncStarter("foo@gmail.com",
+ "refresh_token"));
+ wrapper->Start();
+ base::RunLoop().RunUntilIdle();
+ SimulateRefreshTokenFetched(wrapper, "foo@gmail.com", "foo@gmail.com",
+ "refresh_token");
+}
+
+TEST_F(OneClickSyncStarterWrapperTest, SignInWithEmptyPasswordNoCookie) {
+ OneClickSigninHelper::StartSyncArgs args;
+ args.email = "foo@gmail.com";
+ args.profile = profile();
+ MockStarterWrapper* wrapper = new MockStarterWrapper(
+ args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
+
+ EXPECT_CALL(*wrapper, DisplayErrorBubble(_));
+ wrapper->Start();
+ base::RunLoop().RunUntilIdle();
+}
+
+TEST_F(OneClickSyncStarterWrapperTest, SignInWithEmptyPasswordInvalidCookie) {
+ OneClickSigninHelper::StartSyncArgs args;
+ args.email = "foo@gmail.com";
+ args.profile = profile();
+ MockStarterWrapper* wrapper = new MockStarterWrapper(
+ args, OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
+ SetCookie("LSID=1234; domain=google.com; secure; httponly");
+
+ EXPECT_CALL(*wrapper, DisplayErrorBubble(_));
+ wrapper->Start();
+ base::RunLoop().RunUntilIdle();
+}
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698