Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: gpu/command_buffer/service/program_manager_unittest.cc

Issue 998423005: Updated shader program caching to account for transform feedback varyings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed zmo@'s feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager_unittest.cc
diff --git a/gpu/command_buffer/service/program_manager_unittest.cc b/gpu/command_buffer/service/program_manager_unittest.cc
index 99678f4588cd2215300c548b0b6404d423896873..7401f3c569396cfb266b177ed4fc9f373c5d9da3 100644
--- a/gpu/command_buffer/service/program_manager_unittest.cc
+++ b/gpu/command_buffer/service/program_manager_unittest.cc
@@ -1959,7 +1959,9 @@ class ProgramManagerWithCacheTest : public GpuServiceTest {
cache_->LinkedProgramCacheSuccess(
vertex_shader_->source(),
fragment_shader_->source(),
- &program_->bind_attrib_location_map());
+ &program_->bind_attrib_location_map(),
+ &program_->transform_feedback_varyings(),
+ program_->transform_feedback_buffer_mode());
}
void SetExpectationsForProgramCached() {
@@ -1977,6 +1979,8 @@ class ProgramManagerWithCacheTest : public GpuServiceTest {
vertex_shader,
fragment_shader,
&program->bind_attrib_location_map(),
+ &program_->transform_feedback_varyings(),
+ program_->transform_feedback_buffer_mode(),
_)).Times(1);
}
@@ -1995,6 +1999,8 @@ class ProgramManagerWithCacheTest : public GpuServiceTest {
vertex_shader,
fragment_shader,
&program->bind_attrib_location_map(),
+ &program_->transform_feedback_varyings(),
+ program_->transform_feedback_buffer_mode(),
_)).Times(0);
}
@@ -2017,6 +2023,8 @@ class ProgramManagerWithCacheTest : public GpuServiceTest {
vertex_shader,
fragment_shader,
&program->bind_attrib_location_map(),
+ &program_->transform_feedback_varyings(),
+ program_->transform_feedback_buffer_mode(),
_))
.WillOnce(Return(result));
}

Powered by Google App Engine
This is Rietveld 408576698