gpu/command_buffer/service/memory_program_cache.h - Issue 998423005: Updated shader program caching to account for transform feedback varyings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/memory_program_cache.h

Issue 998423005: Updated shader program caching to account for transform feedback varyings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed zmo@'s feedback Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/memory_program_cache.cc » ('j') | gpu/command_buffer/service/program_cache.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/memory_program_cache.h

diff --git a/gpu/command_buffer/service/memory_program_cache.h b/gpu/command_buffer/service/memory_program_cache.h

index b5862d269345cd42aa9e62c51d02dd9af6310e1d..a574d5dfce6fac29ecd91bf3398822cc66395c04 100644

--- a/gpu/command_buffer/service/memory_program_cache.h

+++ b/gpu/command_buffer/service/memory_program_cache.h

@@ -30,12 +30,17 @@ class GPU_EXPORT MemoryProgramCache : public ProgramCache {

Shader* shader_a,

Shader* shader_b,

const LocationMap* bind_attrib_location_map,

+ const std::vector<std::string>* transform_feedback_varyings,

+ GLenum transform_feedback_buffer_mode,

+ const ShaderCacheCallback& shader_callback) override;

+ void SaveLinkedProgram(

+ GLuint program,

+ const Shader* shader_a,

+ const Shader* shader_b,

+ const LocationMap* bind_attrib_location_map,

+ const std::vector<std::string>* transform_feedback_varyings,

+ GLenum transform_feedback_buffer_mode,

const ShaderCacheCallback& shader_callback) override;

- void SaveLinkedProgram(GLuint program,

- const Shader* shader_a,

- const Shader* shader_b,

- const LocationMap* bind_attrib_location_map,

- const ShaderCacheCallback& shader_callback) override;

void LoadProgram(const std::string& program) override;