Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 998413003: update new string (Closed)

Created:
5 years, 9 months ago by Gang Wu
Modified:
5 years, 9 months ago
Reviewers:
rpop, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync]Enable new sync URL to link to Chrome Away Current string: Signed in as [email]. Manage your synced data on Google Dashboard New strings: Signed in as [email]. Manage your synced data and devices on Chrome Dashboard BUG=402615 Manual test: launch chrome by chrome --force-fieldtrials="ChromeDashboard/Enabled/" log in chrome, and then go to settings, on the top of settings, there should be the new string, click the "Chrome Dashboard", it should bring you to URL("https://google.com/settings/chrome/sync"). Committed: https://crrev.com/0bdea05adc8f4c409053bab44e0a84436b4f2aec Cr-Commit-Position: refs/heads/master@{#320941}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Gang Wu
please take a look for this new string.
5 years, 9 months ago (2015-03-13 00:10:49 UTC) #2
rpop
On 2015/03/13 00:10:49, Gang Wu wrote: > please take a look for this new string. ...
5 years, 9 months ago (2015-03-13 00:13:06 UTC) #3
Gang Wu
On 2015/03/13 00:13:06, rpop wrote: > On 2015/03/13 00:10:49, Gang Wu wrote: > > please ...
5 years, 9 months ago (2015-03-13 03:07:46 UTC) #4
rpop
On 2015/03/13 03:07:46, Gang Wu wrote: > On 2015/03/13 00:13:06, rpop wrote: > > On ...
5 years, 9 months ago (2015-03-13 05:23:43 UTC) #5
Gang Wu
On 2015/03/13 05:23:43, rpop wrote: > On 2015/03/13 03:07:46, Gang Wu wrote: > > On ...
5 years, 9 months ago (2015-03-13 16:43:57 UTC) #6
Gang Wu
adding a trailing period.
5 years, 9 months ago (2015-03-13 16:44:28 UTC) #7
Nicolas Zea
Just to double check, we want to use the old URL now? Not the new ...
5 years, 9 months ago (2015-03-16 21:26:06 UTC) #9
Gang Wu
On 2015/03/16 21:26:06, Nicolas Zea wrote: > Just to double check, we want to use ...
5 years, 9 months ago (2015-03-16 22:01:17 UTC) #10
Nicolas Zea
LGTM
5 years, 9 months ago (2015-03-16 23:14:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998413003/20001
5 years, 9 months ago (2015-03-17 17:12:39 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 18:05:38 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:07:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bdea05adc8f4c409053bab44e0a84436b4f2aec
Cr-Commit-Position: refs/heads/master@{#320941}

Powered by Google App Engine
This is Rietveld 408576698