Created policy QuicAllowed

chrome/browser/io_thread.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_IO_THREAD_H_
 #define CHROME_BROWSER_IO_THREAD_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 312 matching lines @@
 #else
     return NULL;
 #endif
   }
   // Configures QUIC options in |globals| based on the flags in |command_line|
   // as well as the QUIC field trial group and parameters.
   static void ConfigureQuicGlobals(
       const base::CommandLine& command_line,
       base::StringPiece quic_trial_group,
       const VariationParameters& quic_trial_params,
+      bool quic_allowed_by_policy,
       Globals* globals);
 

[Ryan Hamilton, 2015/03/18 18:42:54]

Can you add tests for this new logic in io_thread_unittest.cc?

[peletskyi, 2015/03/20 17:54:47]

Done.

   // Returns true if QUIC should be enabled, either as a result
   // of a field trial or a command line flag.
   static bool ShouldEnableQuic(
       const base::CommandLine& command_line,
-      base::StringPiece quic_trial_group);
+      base::StringPiece quic_trial_group,
+      bool quic_allowed_by_policy);
 
   // Returns true if QUIC should be enabled for proxies, either as a result
   // of a field trial or a command line flag.
   static bool ShouldEnableQuicForProxies(
       const base::CommandLine& command_line,
-      base::StringPiece quic_trial_group);
+      base::StringPiece quic_trial_group,
+      bool quic_allowed_by_policy);
 
   // Returns true if the selection of the ephemeral port in bind() should be
   // performed by Chromium, and false if the OS should select the port.  The OS
   // option is used to prevent Windows from posting a security security warning
   // dialog.
   static bool ShouldEnableQuicPortSelection(
       const base::CommandLine& command_line);
 
   // Returns true if QUIC packet pacing should be negotiated during the
   // QUIC handshake.
@@ skipping 110 matching lines @@
   scoped_ptr<net::ProxyConfigService> system_proxy_config_service_;
 
   scoped_ptr<PrefProxyConfigTracker> pref_proxy_config_tracker_;
 
   scoped_refptr<net::URLRequestContextGetter>
       system_url_request_context_getter_;
 
   // True if SPDY is disabled by policy.
   bool is_spdy_disabled_by_policy_;
 
+  // True if QUIC is allowed by policy.
+  bool is_quic_allowed_by_policy_;

[Ryan Hamilton, 2015/03/18 18:42:54]

heh, it's unfortunate that the polarity of this policy is reverse from SPDY. How
hard would it be to make the polarity match?

[peletskyi, 2015/03/20 17:54:47]

Unfortunately one is not allowed not give name "QuicDisabled" to the policy. The
best name that matches the goals of this policy we could came up with is
"QuicAllowed". And this variable just reflects the value and the meaning of the
policy.

+
   const base::TimeTicks creation_time_;
 
   base::WeakPtrFactory<IOThread> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IOThread);
 };
 
 #endif  // CHROME_BROWSER_IO_THREAD_H_