Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: sync/test/fake_server/android/fake_server_helper_android.h

Issue 998373004: Sync: Generalize entity injection in Android tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/test/fake_server/android/fake_server_helper_android.h
diff --git a/sync/test/fake_server/android/fake_server_helper_android.h b/sync/test/fake_server/android/fake_server_helper_android.h
index c952141197ee4d5628113e3b24164fd937fb4be4..d7449d772955afba50cce98cfdde5bdb7b907e38 100644
--- a/sync/test/fake_server/android/fake_server_helper_android.h
+++ b/sync/test/fake_server/android/fake_server_helper_android.h
@@ -40,15 +40,12 @@ class FakeServerHelperAndroid {
jstring model_type_string,
jstring name);
- // Injects a typed URL into |fake_server|.
- //
- // TODO(pvalenzuela): Generalize this method to accept a serialized
- // EntitySpecifics so that a separate method is not required for each data
- // type.
- void InjectTypedUrl(JNIEnv* env,
- jobject obj,
- jlong fake_server,
- jstring url);
+ // Injects a UniqueClientEntity into |fake_server|.
+ void InjectUniqueClientEntity(JNIEnv* env,
+ jobject obj,
+ jlong fake_server,
+ jstring name,
+ jbyteArray serialized_entity_specifics);
private:
virtual ~FakeServerHelperAndroid();

Powered by Google App Engine
This is Rietveld 408576698