Sync: Generalize entity injection in Android tests

chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java

Index: chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java
diff --git a/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java b/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java
index 0965620d4454c50917f84e4b6259ea24396075a8..49db8c4e575f2dc82111babbb441d6d8e09faada 100644
--- a/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java
+++ b/chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java
@@ -26,6 +26,9 @@ import org.chromium.content.browser.test.util.JavaScriptUtils;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.sync.AndroidSyncSettings;
 import org.chromium.sync.internal_api.pub.base.ModelType;
+import org.chromium.sync.protocol.EntitySpecifics;
+import org.chromium.sync.protocol.SyncEnums;
+import org.chromium.sync.protocol.TypedUrlSpecifics;
 import org.chromium.sync.signin.AccountManagerHelper;
 import org.chromium.sync.signin.ChromeSigninController;
 import org.chromium.sync.test.util.MockAccountManager;
@@ -260,9 +263,17 @@ public class SyncTest extends ChromeShellTestBase {
     @Feature({"Sync"})
     public void testDownloadTypedUrl() throws InterruptedException {
         setupTestAccountAndSignInToSync(FOREIGN_SESSION_TEST_MACHINE_ID);
-
         assertLocalEntityCount("Typed URLs", 0);
-        mFakeServerHelper.injectTypedUrl("data:text,testDownloadTypedUrl");
+
+        String url = "data:text,testDownloadTypedUrl";
+        EntitySpecifics specifics = new EntitySpecifics();
+        specifics.typedUrl = new TypedUrlSpecifics();
+        specifics.typedUrl.url = url;
+        specifics.typedUrl.title = url;
+        specifics.typedUrl.visits = new long[]{1L};
+        specifics.typedUrl.visitTransitions = new int[]{SyncEnums.TYPED};
+        mFakeServerHelper.injectUniqueClientEntity(url /* name */, specifics);

[nyquist, 2015/03/24 00:25:35]

This is so cool!

[pval...(no longer on Chromium), 2015/03/26 21:17:57]

:) it'll be cooler when we have tests for all/most types

+
         SyncTestUtil.triggerSyncAndWaitForCompletion(mContext);
         assertLocalEntityCount("Typed URLs", 1);