Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: sync/sync_tests.gypi

Issue 998373004: Sync: Generalize entity injection in Android tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/sync_tests.gypi
diff --git a/sync/sync_tests.gypi b/sync/sync_tests.gypi
index 8f2b35b4198038fade26c9777d4d65acca517b31..61fd7632dbddb84ef5f129b4a6f15593fcfd5431 100644
--- a/sync/sync_tests.gypi
+++ b/sync/sync_tests.gypi
@@ -469,6 +469,43 @@
'includes': [ '../build/jni_generator.gypi' ],
},
{
+ # before submit:
+ # create GN version
pval...(no longer on Chromium) 2015/03/26 21:17:57 Do you consider this a requirement for this CL? I
nyquist 2015/04/01 00:01:00 I'd trust you to follow up on a TODO.
pval...(no longer on Chromium) 2015/04/09 18:01:18 todo+bug added
+ 'target_name': 'test_support_sync_proto_java',
+ 'type': 'none',
+ 'variables': {
+ 'proto_in_dir': '<(INTERMEDIATE_DIR)/sync_protos',
+ # Set this variable so that sync_proto_source_paths refers to the
+ # temporary proto definitions created here.
+ 'sync_proto_sources_dir': '<(INTERMEDIATE_DIR)/sync_protos',
+ },
+ 'actions': [
+ {
+ 'action_name': 'run_script',
+ 'inputs': [
+ 'protocol/prepare_protos_for_java_tests.py',
+ # Use the original list of proto files (defined in sync.gyp).
+ '<@(sync_proto_sources)',
+ ],
+ 'outputs': [
+ '<@(sync_proto_source_paths)',
+ ],
+ 'action': [
+ 'python',
+ 'protocol/prepare_protos_for_java_tests.py',
+ '--output_dir',
+ '<(INTERMEDIATE_DIR)/sync_protos',
+ # Use the original list of proto files (defined in sync.gyp).
+ '<@(sync_proto_sources)'
+ ],
+ },
+ ],
+ 'sources': [
+ '<@(sync_proto_source_paths)',
+ ],
+ 'includes': ['protocol/protocol.gypi', '../build/protoc_java.gypi'],
+ },
+ {
# GN: //sync:test_support_sync_fake_server_android
'target_name': 'test_support_sync_fake_server_android',
'type': 'static_library',

Powered by Google App Engine
This is Rietveld 408576698