CrossProcessFrameConnector configuration happening too soon

CrossProcessFrameConnector configuration happening too soon

When navigating an OOPIF back into the same site instance as its parent,
RenderFrameProxyHost::SetChildRWHView() was being called on the proxy
immediately before the RFPH was removed from the
RenderFrameHostManager's proxy list. This was causing the
CrossProcessFrameConnector to briefly become attached to the parent
frame's RenderWidgetHostView, and resize the parent frame's viewport
erroneously.

Delaying the call to SetChildRWHView until after the RFPH is cleared
from the proxy list corrects this problem.

BUG=453500
Committed: https://crrev.com/4b36c0fb3320c92764f255f6d51c3c06790d2798
Cr-Commit-Position: refs/heads/master@{#320354}

[kenrb, 2015-03-12 15:51:07]

kenrb@chromium.org changed reviewers:
+ nasko@chromium.org

[kenrb, 2015-03-12 15:53:24]

Nasko: PTAL?

[nasko, 2015-03-12 17:32:13]

LGTM with a couple of nits.

https://codereview.chromium.org/998353003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/998353003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager.cc:1674: // an out of
process frame to return to the same process as its parent, the
nit: "out-of-process"

https://codereview.chromium.org/998353003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager.cc:1679: if
(proxy_to_parent) {
nit: this is a oneliner, so no need for {}, I've missed this before, sorry!

[kenrb, 2015-03-12 19:03:35]

https://codereview.chromium.org/998353003/diff/1/content/browser/frame_host/r...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/998353003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager.cc:1674: // an out of
process frame to return to the same process as its parent, the
On 2015/03/12 17:32:13, nasko wrote:
> nit: "out-of-process"

Done.

https://codereview.chromium.org/998353003/diff/1/content/browser/frame_host/r...
content/browser/frame_host/render_frame_host_manager.cc:1679: if
(proxy_to_parent) {
On 2015/03/12 17:32:13, nasko wrote:
> nit: this is a oneliner, so no need for {}, I've missed this before, sorry!

Done.

[kenrb, 2015-03-12 19:03:45]

The CQ bit was checked by kenrb@chromium.org

[kenrb, 2015-03-12 19:03:45]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/998353003/#ps20001 (title:
"Comments addressed")

[commit-bot: I haz the power, 2015-03-12 19:04:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998353003/20001

[commit-bot: I haz the power, 2015-03-12 20:11:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-12 20:12:01]

Patchset 2 (id:??) landed as
https://crrev.com/4b36c0fb3320c92764f255f6d51c3c06790d2798
Cr-Commit-Position: refs/heads/master@{#320354}