chrome/renderer/resources/extensions/platform_keys_custom_bindings.js - Issue 998293002: chrome.platformKeys.getKeyPair: Check requested algorithm against certificate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/platform_keys_custom_bindings.js

Issue 998293002: chrome.platformKeys.getKeyPair: Check requested algorithm against certificate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@require_alg_name

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/platform_keys_internal.idl ('K') | « chrome/renderer/resources/extensions/platform_keys/get_public_key.js ('k') | chrome/test/data/extensions/api_test/platform_keys/basic.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/platform_keys_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/platform_keys_custom_bindings.js b/chrome/renderer/resources/extensions/platform_keys_custom_bindings.js

index 9320e021722770c8020e6753d9d49d439038f32c..1f30c1fcaaf845a03a50dc5356696dafb08e8382 100644

--- a/chrome/renderer/resources/extensions/platform_keys_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/platform_keys_custom_bindings.js

@@ -49,6 +49,10 @@ binding.registerCustomHook(function(api) {

apiFunctions.setHandleRequest(

'getKeyPair', function(cert, params, callback) {

getPublicKey(cert, params, function(publicKey, algorithm) {

+ if (chrome.runtime.lastError) {

+ callback();

+ return;

+ }

callback(createPublicKey(publicKey, algorithm),

createPrivateKey(publicKey, algorithm));

});