Make presubmit check that #if or #ifdef does not come before includes

Make presubmit check that #if or #ifdef does not come before includes.

BUG=skia:3362
Committed: https://skia.googlesource.com/skia/+/01cbf6c4673b805ab80e2b37e35eb4c89b135a1b

[rmistry, 2015-03-12 12:36:48]

rmistry@google.com changed reviewers:
+ borenet@google.com

[borenet, 2015-03-12 12:47:48]

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py#newcode84
PRESUBMIT.py:84: copyright_end_pattern = re.compile(' \*\/.*\n')
Suggest using '^\/\*w*$' etc

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py#newcode90
PRESUBMIT.py:90: empty_line_pattern = re.compile('\w*\n\w*')
Shouldn't this be '^$' ?  Why match characters in a line that's supposed to be
empty?

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py#newcode105
PRESUBMIT.py:105: pass
Why not break here?

[rmistry, 2015-03-12 13:12:59]

Patchset #4 (id:60001) has been deleted

[rmistry, 2015-03-12 13:13:05]

Patchset #4 (id:80001) has been deleted

[rmistry, 2015-03-12 13:13:59]

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py#newcode84
PRESUBMIT.py:84: copyright_end_pattern = re.compile(' \*\/.*\n')
On 2015/03/12 12:47:48, borenet wrote:
> Suggest using '^\/\*w*$' etc

Yes, I forgot to do this. Done.

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py#newcode90
PRESUBMIT.py:90: empty_line_pattern = re.compile('\w*\n\w*')
On 2015/03/12 12:47:48, borenet wrote:
> Shouldn't this be '^$' ?  Why match characters in a line that's supposed to be
> empty?

This is to treat lines that have only whitespaces in it as empty lines. If there
is a '  ' line and empty_line_pattern does not catch it then it will be treated
as the first real line and will be tested for '#if' and '#ifdef'.

https://codereview.chromium.org/998273002/diff/20001/PRESUBMIT.py#newcode105
PRESUBMIT.py:105: pass
On 2015/03/12 12:47:48, borenet wrote:
> Why not break here?

Either way works. I prefer having less places to exit whenever possible.

[borenet, 2015-03-12 13:19:42]

LGTM

[rmistry, 2015-03-12 14:27:57]

I changed the code a little bit to handle single line comments as well. Could
you please take another quick look?

[borenet, 2015-03-12 14:30:43]

LGTM but added a note which may or may not be a problem

https://codereview.chromium.org/998273002/diff/120001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/998273002/diff/120001/PRESUBMIT.py#newcode85
PRESUBMIT.py:85: single_line_comment_pattern = re.compile('^//.*$')
Note: none of these seem to handle the case where there are spaces before the
comment begins.

[rmistry, 2015-03-12 14:42:50]

https://codereview.chromium.org/998273002/diff/120001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/998273002/diff/120001/PRESUBMIT.py#newcode85
PRESUBMIT.py:85: single_line_comment_pattern = re.compile('^//.*$')
On 2015/03/12 14:30:41, borenet wrote:
> Note: none of these seem to handle the case where there are spaces before the
> comment begins.

Done.

[rmistry, 2015-03-12 14:42:58]

The CQ bit was checked by rmistry@google.com

[rmistry, 2015-03-12 14:42:59]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com
Link to the patchset: https://codereview.chromium.org/998273002/#ps160001
(title: "Cleanup")

[commit-bot: I haz the power, 2015-03-12 14:43:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/998273002/160001

[commit-bot: I haz the power, 2015-03-12 14:48:46]

Committed patchset #7 (id:160001) as
https://skia.googlesource.com/skia/+/01cbf6c4673b805ab80e2b37e35eb4c89b135a1b