Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: src/global-handles.h

Issue 998253006: two pass phantom collection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/global-handles.h
diff --git a/src/global-handles.h b/src/global-handles.h
index d1d5d1ebe68696a668816edac7ec10012f11b266..b41f86e460d521cdee9dbdd19db3c52b3af718e1 100644
--- a/src/global-handles.h
+++ b/src/global-handles.h
@@ -349,17 +349,23 @@ class GlobalHandles {
class GlobalHandles::PendingPhantomCallback {
public:
typedef v8::WeakCallbackInfo<void> Data;
- PendingPhantomCallback(Node* node, Data data, Data::Callback callback)
- : node_(node), data_(data), callback_(callback) {}
+ PendingPhantomCallback(Node* node, Data::Callback callback, void* parameter,
+ void* internal_field_0, void* internal_field_1)
+ : node_(node), callback_(callback), parameter_(parameter) {
+ internal_fields_[0] = internal_field_0;
+ internal_fields_[1] = internal_field_1;
+ }
- void invoke();
+ void Invoke(Isolate* isolate);
Node* node() { return node_; }
+ Data::Callback callback() { return callback_; }
private:
Node* node_;
- Data data_;
Data::Callback callback_;
+ void* parameter_;
+ void* internal_fields_[2];
};

Powered by Google App Engine
This is Rietveld 408576698