include/v8-util.h - Issue 998253006: two pass phantom collection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8-util.h

Issue 998253006: two pass phantom collection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8-util.h

diff --git a/include/v8-util.h b/include/v8-util.h

index 21990a8fd9c681c91c2599ab40434520a22b3a78..8d7f58e9d71d825caf02326a3d50937835d911f7 100644

--- a/include/v8-util.h

+++ b/include/v8-util.h

@@ -476,7 +476,6 @@ class GlobalValueMap : public PersistentValueMapBase<K, V, Traits> {

K key = Traits::KeyFromWeakCallbackInfo(data);

persistentValueMap->RemoveWeak(key);

Traits::DisposeWeak(data.GetIsolate(), data, key);

- Traits::DisposeCallbackData(data.GetParameter());

}

};

« no previous file with comments | « include/v8.h ('k') | src/global-handles.h » ('j') | src/global-handles.h » ('J')