src/liveedit.cc - Issue 998253005: Debugger: deduplicate shared function info when setting script break points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/liveedit.cc

Issue 998253005: Debugger: deduplicate shared function info when setting script break points. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: revert change to liveedit test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/liveedit.cc

diff --git a/src/liveedit.cc b/src/liveedit.cc

index b6cc124ab11d018c4798ba1c4abd371f598360b1..c03d8d3e938f98da66c56d484e88d88ef97ce2ad 100644

--- a/src/liveedit.cc

+++ b/src/liveedit.cc

@@ -1222,6 +1222,7 @@ void LiveEdit::SetFunctionScript(Handle<JSValue> function_wrapper,

UnwrapSharedFunctionInfoFromJSValue(function_wrapper);

CHECK(script_handle->IsScript() || script_handle->IsUndefined());

shared_info->set_script(*script_handle);

+ shared_info->DisableOptimization(kLiveEdit);

function_wrapper->GetIsolate()->compilation_cache()->Remove(shared_info);

}

« src/factory.cc ('K') | « src/factory.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »