Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/devtools/protocol/service_worker_handler.cc ('K') | « content/browser/service_worker/service_worker_info.cc ('k') | content/browser/service_worker/service_worker_registration.cc » ('j') | content/browser/service_worker/service_worker_storage.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_internals_ui.cc
diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc
index 4a3d0fe0b225b611e6a2a958f83d0652e523a721..bf075d83d34f3aa882a736da7b0e2c077f038253 100644
--- a/content/browser/service_worker/service_worker_internals_ui.cc
+++ b/content/browser/service_worker/service_worker_internals_ui.cc
@@ -304,13 +304,15 @@ class ServiceWorkerInternalsUI::PartitionObserver
: partition_id_(partition_id), web_ui_(web_ui) {}
~PartitionObserver() override {}
// ServiceWorkerContextObserver overrides:
- void OnRunningStateChanged(int64 version_id) override {
+ void OnRunningStateChanged(int64 version_id,
+ ServiceWorkerVersion::RunningStatus) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
web_ui_->CallJavascriptFunction(
"serviceworker.onRunningStateChanged", FundamentalValue(partition_id_),
StringValue(base::Int64ToString(version_id)));
}
- void OnVersionStateChanged(int64 version_id) override {
+ void OnVersionStateChanged(int64 version_id,
+ ServiceWorkerVersion::Status) override {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
web_ui_->CallJavascriptFunction(
"serviceworker.onVersionStateChanged",
« content/browser/devtools/protocol/service_worker_handler.cc ('K') | « content/browser/service_worker/service_worker_info.cc ('k') | content/browser/service_worker/service_worker_registration.cc » ('j') | content/browser/service_worker/service_worker_storage.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698