Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use DCHECK_CURRENTLY_ON Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 60991352a81c79f3d039f3139918820416aadf0a..06e1fbb055be99c108f89e1736ae45e859478684 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -347,6 +347,11 @@ void ServiceWorkerContextCore::AddLiveRegistration(
ServiceWorkerRegistration* registration) {
DCHECK(!GetLiveRegistration(registration->id()));
live_registrations_[registration->id()] = registration;
+ if (observer_list_.get()) {
+ observer_list_->Notify(FROM_HERE,
+ &ServiceWorkerContextObserver::OnNewLiveRegistration,
+ registration->id(), registration->pattern());
+ }
}
void ServiceWorkerContextCore::RemoveLiveRegistration(int64 id) {
@@ -363,6 +368,12 @@ void ServiceWorkerContextCore::AddLiveVersion(ServiceWorkerVersion* version) {
DCHECK(!GetLiveVersion(version->version_id()));
live_versions_[version->version_id()] = version;
version->AddListener(this);
+ if (observer_list_.get()) {
+ observer_list_->Notify(FROM_HERE,
+ &ServiceWorkerContextObserver::OnNewLiveVersion,
+ version->version_id(), version->registration_id(),
+ version->script_url());
+ }
}
void ServiceWorkerContextCore::RemoveLiveVersion(int64 id) {
@@ -461,7 +472,7 @@ void ServiceWorkerContextCore::OnRunningStateChanged(
return;
observer_list_->Notify(FROM_HERE,
&ServiceWorkerContextObserver::OnRunningStateChanged,
- version->version_id());
+ version->version_id(), version->running_status());
}
void ServiceWorkerContextCore::OnVersionStateChanged(
@@ -470,7 +481,7 @@ void ServiceWorkerContextCore::OnVersionStateChanged(
return;
observer_list_->Notify(FROM_HERE,
&ServiceWorkerContextObserver::OnVersionStateChanged,
- version->version_id());
+ version->version_id(), version->status());
}
void ServiceWorkerContextCore::OnErrorReported(

Powered by Google App Engine
This is Rietveld 408576698