Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: content/browser/geofencing/geofencing_manager_unittest.cc

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use DCHECK_CURRENTLY_ON Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geofencing/geofencing_manager_unittest.cc
diff --git a/content/browser/geofencing/geofencing_manager_unittest.cc b/content/browser/geofencing/geofencing_manager_unittest.cc
index 3d3c79a0cc9b26fc6e233614444f8aa458c71db6..05e301916f03f08b4db0637bc799c1b67711daf9 100644
--- a/content/browser/geofencing/geofencing_manager_unittest.cc
+++ b/content/browser/geofencing/geofencing_manager_unittest.cc
@@ -157,9 +157,12 @@ class GeofencingManagerTest : public testing::Test {
EXPECT_FALSE(called);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(called);
-
- return make_scoped_refptr(new ServiceWorkerRegistration(
- pattern, registration_id, helper_->context()->AsWeakPtr()));
+ scoped_refptr<ServiceWorkerRegistration> worker(
+ new ServiceWorkerRegistration(pattern, registration_id,
+ helper_->context()->AsWeakPtr()));
+ // ServiceWorkerRegistration posts a notification task on construction.
+ base::RunLoop().RunUntilIdle();
+ return worker;
}
void UnregisterServiceWorker(

Powered by Google App Engine
This is Rietveld 408576698