Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use DCHECK_CURRENTLY_ON Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index ba685028a2410993860aca0c6bcfed09e5a4cf0d..16caa98edbfcff13cecd643bc02436d5d9d3528d 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -23,6 +23,7 @@
namespace content {
class RenderFrameHostImpl;
+class ServiceWorkerContextWatcher;
class ServiceWorkerContextWrapper;
namespace devtools {
@@ -54,8 +55,6 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
void WorkerDestroyed(ServiceWorkerDevToolsAgentHost* host) override;
private:
- class ContextObserver;
-
// DevToolsAgentHostClient overrides.
void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
const std::string& message) override;
@@ -69,14 +68,13 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
const std::vector<ServiceWorkerRegistrationInfo>& registrations);
void OnWorkerVersionUpdated(
const std::vector<ServiceWorkerVersionInfo>& registrations);
- void OnWorkerRegistrationDeleted(int64 registration_id);
scoped_refptr<ServiceWorkerContextWrapper> context_;
scoped_ptr<Client> client_;
ServiceWorkerDevToolsAgentHost::Map attached_hosts_;
bool enabled_;
std::set<GURL> urls_;
- scoped_refptr<ContextObserver> context_observer_;
+ scoped_refptr<ServiceWorkerContextWatcher> context_watcher_;
RenderFrameHostImpl* render_frame_host_;
base::WeakPtrFactory<ServiceWorkerHandler> weak_factory_;
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698