content/browser/service_worker/service_worker_info.h - Issue 998173002: Revise ServiceWorker DevTools protocols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_info.h

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated kinuko's comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_watcher.cc ('k') | content/browser/service_worker/service_worker_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_info.h

diff --git a/content/browser/service_worker/service_worker_info.h b/content/browser/service_worker/service_worker_info.h

index 6276eb04e5e95de337a6581737cdc40fbdc4858b..2b217687df0a08dda6fde17dd47521c573bfc15d 100644

--- a/content/browser/service_worker/service_worker_info.h

+++ b/content/browser/service_worker/service_worker_info.h

@@ -13,7 +13,7 @@

namespace content {

-class CONTENT_EXPORT ServiceWorkerVersionInfo {

+struct CONTENT_EXPORT ServiceWorkerVersionInfo {

public:

ServiceWorkerVersionInfo();

ServiceWorkerVersionInfo(ServiceWorkerVersion::RunningStatus running_status,

@@ -36,12 +36,17 @@ class CONTENT_EXPORT ServiceWorkerVersionInfo {

int devtools_agent_route_id;

};

-class CONTENT_EXPORT ServiceWorkerRegistrationInfo {

+struct CONTENT_EXPORT ServiceWorkerRegistrationInfo {

public:

+ enum DeleteFlag { IsNotDeleted, IsDeleted };

kinuko 2015/03/13 12:17:24 enum name should be CAPITAL_NAME (or kCamelName, l

horo 2015/03/13 16:03:30 Done.

ServiceWorkerRegistrationInfo();

+ ServiceWorkerRegistrationInfo(const GURL& pattern,

+ int64 registration_id,

+ DeleteFlag delete_flag);

ServiceWorkerRegistrationInfo(

const GURL& pattern,

int64 registration_id,

+ DeleteFlag delete_flag,

const ServiceWorkerVersionInfo& active_version,

const ServiceWorkerVersionInfo& waiting_version,

const ServiceWorkerVersionInfo& installing_version,

@@ -50,6 +55,7 @@ class CONTENT_EXPORT ServiceWorkerRegistrationInfo {

GURL pattern;

int64 registration_id;

+ DeleteFlag delete_flag;

ServiceWorkerVersionInfo active_version;

ServiceWorkerVersionInfo waiting_version;

ServiceWorkerVersionInfo installing_version;