content/browser/service_worker/service_worker_browsertest.cc - Issue 998173002: Revise ServiceWorker DevTools protocols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated kinuko's comment Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_browsertest.cc

diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc

index c6f877baf870396d1a90b4f42eb11c119225f0af..de321b572c6c18a36e52ff0ee9494f2a89b166ff 100644

--- a/content/browser/service_worker/service_worker_browsertest.cc

+++ b/content/browser/service_worker/service_worker_browsertest.cc

@@ -157,7 +157,8 @@ class WorkerActivatedObserver

RunOnIOThread(base::Bind(&WorkerActivatedObserver::InitOnIOThread, this));

}

// ServiceWorkerContextObserver overrides.

- void OnVersionStateChanged(int64 version_id) override {

+ void OnVersionStateChanged(int64 version_id,

+ ServiceWorkerVersion::Status) override {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

const ServiceWorkerVersion* version =

context_->context()->GetLiveVersion(version_id);