Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: content/browser/service_worker/service_worker_info.h

Issue 998173002: Revise ServiceWorker DevTools protocols. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ServiceWorkerContextWatcher Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_info.h
diff --git a/content/browser/service_worker/service_worker_info.h b/content/browser/service_worker/service_worker_info.h
index 6276eb04e5e95de337a6581737cdc40fbdc4858b..7bb9f9cd481f5b07d8fd499c808578cb5283d703 100644
--- a/content/browser/service_worker/service_worker_info.h
+++ b/content/browser/service_worker/service_worker_info.h
@@ -39,9 +39,13 @@ class CONTENT_EXPORT ServiceWorkerVersionInfo {
class CONTENT_EXPORT ServiceWorkerRegistrationInfo {
public:
kinuko 2015/03/13 09:09:21 nit: could be a struct if all fields are public
horo 2015/03/13 10:03:50 Done.
ServiceWorkerRegistrationInfo();
+ ServiceWorkerRegistrationInfo(const GURL& pattern,
+ int64 registration_id,
+ bool is_deleted);
kinuko 2015/03/13 09:09:21 nit: prefer using enum over boolean in general
horo 2015/03/13 10:03:50 Done.
ServiceWorkerRegistrationInfo(
const GURL& pattern,
int64 registration_id,
+ bool is_deleted,
const ServiceWorkerVersionInfo& active_version,
const ServiceWorkerVersionInfo& waiting_version,
const ServiceWorkerVersionInfo& installing_version,
@@ -50,6 +54,7 @@ class CONTENT_EXPORT ServiceWorkerRegistrationInfo {
GURL pattern;
int64 registration_id;
+ bool is_deleted;
ServiceWorkerVersionInfo active_version;
ServiceWorkerVersionInfo waiting_version;
ServiceWorkerVersionInfo installing_version;

Powered by Google App Engine
This is Rietveld 408576698