Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 998163004: [es6] Object.getOwnPropertyDescriptor should wrap primitives (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 8 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Object.getOwnPropertyDescriptor should wrap primitives In ES6 Object.getOwnPropertyDescriptor should call ToObject, which means that primitive values will return descriptors from the wrapper. BUG=v8:3964 LOG=N R=adamk, rossberg@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/4374941837ac0a291c7f4444a345d23bd23dc961 Cr-Commit-Position: refs/heads/master@{#27569}

Patch Set 1 #

Patch Set 2 : Add exceptions to test262 #

Patch Set 3 : Update test262-es6.status #

Patch Set 4 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M src/v8natives.js View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
A test/mjsunit/get-own-property-descriptor-non-objects.js View 1 chunk +34 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-03-19 22:08:03 UTC) #1
adamk
lgtm
5 years, 9 months ago (2015-03-20 08:16:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998163004/1
5 years, 9 months ago (2015-03-20 14:36:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/4093)
5 years, 9 months ago (2015-03-20 15:16:10 UTC) #6
arv (Not doing code reviews)
Add exceptions to test262
5 years, 9 months ago (2015-03-20 16:56:20 UTC) #7
arv (Not doing code reviews)
Update test262-es6.status
5 years, 8 months ago (2015-03-31 16:03:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998163004/40001
5 years, 8 months ago (2015-03-31 21:18:56 UTC) #11
commit-bot: I haz the power
Failed to apply patch for test/test262/test262.status: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-01 00:23:44 UTC) #13
arv (Not doing code reviews)
git rebase
5 years, 8 months ago (2015-04-01 14:35:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998163004/60001
5 years, 8 months ago (2015-04-01 14:36:07 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-01 15:45:07 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 15:45:16 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4374941837ac0a291c7f4444a345d23bd23dc961
Cr-Commit-Position: refs/heads/master@{#27569}

Powered by Google App Engine
This is Rietveld 408576698