Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(96)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: lib/src/js/keywords.dart
Issue
998043002
:
Fixes in codegen and test script (Closed)
Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set:
Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
.gitignore
lib/src/codegen/js_codegen.dart
lib/src/js/js_ast.dart
lib/src/js/keywords.dart
lib/src/js/printer.dart
lib/src/utils.dart
test/codegen/8invalid-chars.in+file_name.dart
test/codegen/expect/8invalid-chars.in+file_name.js
test/codegen/expect/8invalid-chars.in+file_name.txt
test/codegen/expect/server_mode/dev_compiler/runtime/dart_runtime.js
test/codegen/expect/server_mode/dev_compiler/runtime/harmony_feature_check.js
test/codegen/expect/server_mode/dev_compiler/runtime/messages.css
test/codegen/expect/server_mode/dev_compiler/runtime/messages_widget.js
test/codegen/expect/try_catch.js
test/codegen/expect/try_catch.txt
test/codegen/try_catch.dart
test/test.sh
View unified diff
|
Download patch
« no previous file with comments
|
« lib/src/js/js_ast.dart
('k') |
lib/src/js/printer.dart »
('j') |
test/test.sh »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
library js_keywords;
2
3
bool isJsKeyword(String keyword) {
4
switch (keyword) {
5
case "break":
6
case "case":
7
case "catch":
8
case "class":
9
case "const":
10
case "continue":
11
case "debugger":
12
case "default":
13
case "delete":
14
case "do":
15
case "else":
16
case "export":
17
case "extends":
18
case "finally":
19
case "for":
20
case "function":
21
case "if":
22
case "import":
23
case "in":
24
case "instanceof":
25
case "let":
26
case "new":
27
case "return":
28
case "static":
29
case "super":
30
case "switch":
31
case "this":
32
case "throw":
33
case "try":
34
case "typeof":
35
case "var":
36
case "void":
37
case "while":
38
case "with":
39
case "yield":
40
return true;
41
}
42
return false;
43
}
44
OLD
NEW
« no previous file with comments
|
« lib/src/js/js_ast.dart
('k') |
lib/src/js/printer.dart »
('j') |
test/test.sh »
('J')
Issue 998043002: Fixes in codegen and test script (Closed)
Created 5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified 5 years, 9 months ago
Reviewers: Jennifer Messerly
Base URL: git@github.com:dart-lang/dev_compiler.git@master
Comments: 13
This is Rietveld
408576698