|
Carry the client ID from the database all the way through upload.
The client ID is added to a new field, MinidumpCrashpadInfo::client_id,
in each minidump file that is written. The ProcessSnapshot::ClientID()
gives access to value at the snapshot level. In the upload thread,
client IDs are retrieved from minidump files and used to populate the
“guid” HTTP form parameter.
The Breakpad client supplies these values at upload without hyphens and
with all capital letters. Currently, the Crashpad client uses hyphens
and lowercase letters when communicating with a Breakpad server.
TEST=crashpad_minidump_test MinidumpCrashpadInfoWriter.*,
crashpad_snapshot_test ProcessSnapshotMinidump.*,
run_with_crashpad --handler crashpad_handler \
-a --database=/tmp/crashpad_db \
-a --url=https://clients2.google.com/cr/staging_report \
-a --annotation=prod=crashpad \
-a --annotation=ver=0.7.0 \
crashy_program
R=rsesek@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/359bdd86225c144f6b24a365260b85dc617be308
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+195 lines, -10 lines) |
Patch |
|
M |
handler/mac/crash_report_exception_handler.cc
|
View
|
|
2 chunks |
+11 lines, -0 lines |
0 comments
|
Download
|
|
M |
handler/mac/crash_report_upload_thread.cc
|
View
|
|
4 chunks |
+21 lines, -9 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_crashpad_info_writer.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_crashpad_info_writer.cc
|
View
|
|
3 chunks |
+13 lines, -1 line |
0 comments
|
Download
|
|
M |
minidump/minidump_crashpad_info_writer_test.cc
|
View
|
|
4 chunks |
+38 lines, -0 lines |
0 comments
|
Download
|
|
M |
minidump/minidump_extensions.h
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/mac/process_snapshot_mac.h
|
View
|
|
4 chunks |
+10 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/mac/process_snapshot_mac.cc
|
View
|
|
2 chunks |
+6 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/minidump/process_snapshot_minidump.h
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/minidump/process_snapshot_minidump.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/minidump/process_snapshot_minidump_test.cc
|
View
|
|
3 chunks |
+51 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/process_snapshot.h
|
View
|
|
2 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/test/test_process_snapshot.h
|
View
|
|
4 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
snapshot/test/test_process_snapshot.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (1 generated)
|