Issue 998009: Add override to enable local minidumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 998009: Add override to enable local minidumps (Closed)

Created:
10 years, 9 months ago by krisr

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Patch Set 2 : Fix comment grammar #

Patch Set 4 : Have minidumps dumped on the stateful paritition #

Patch Set 5 : Fix core dumps location in echo #

Created: 10 years, 9 months ago

		Unified diffs	Side-by-side diffs	Stats (+17 lines, -3 lines)
	M	session_manager_setup.sh	View	2 chunks	+17 lines, -3 lines	0 comments

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

http://codereview.chromium.org/998009/diff/5001/6001 File session_manager_setup.sh (right): http://codereview.chromium.org/998009/diff/5001/6001#newcode34 session_manager_setup.sh:34: if [ -f /mnt/stateful_partition/etc/enable_chromium_minidumps ] ; then can we ...

10 years, 9 months ago (2010-03-18 00:20:33 UTC) #2

krisr

Changes made. On Wed, Mar 17, 2010 at 5:20 PM, <cmasone@chromium.org> wrote: > > http://codereview.chromium.org/998009/diff/5001/6001 ...

10 years, 9 months ago (2010-03-18 17:33:37 UTC) #3

Chris Masone

10 years, 9 months ago (2010-03-18 19:29:10 UTC) #5

On 2010/03/18 17:37:50, cmasone wrote:
> lgtm

committed as

http://git.chromium.org/cgi-bin/gitweb.cgi?p=login_manager.git;a=commit;h=874...

Expand Messages | Collapse Messages

Issue 998009: Add override to enable local minidumps (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix comment grammar #

Patch Set 3 : Fixed indent #

Patch Set 4 : Have minidumps dumped on the stateful paritition #

Patch Set 5 : Fix core dumps location in echo #

Messages