Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 998003002: Fix some lint warnings for android_webview_test_apk (Closed)

Created:
5 years, 9 months ago by boliu
Modified:
5 years, 9 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some lint warnings for android_webview_test_apk Reorder uses-sdk and uses-permission to above application tag. Remove INJECT_EVENTS permission since we don't need it. BUG= Committed: https://crrev.com/fc6b8fea5a3ed8cf617444263d99478c054fb0d9 Cr-Commit-Position: refs/heads/master@{#320132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M android_webview/javatests/AndroidManifest.xml View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
One more..
5 years, 9 months ago (2015-03-11 18:35:16 UTC) #2
hush (inactive)
lgtm
5 years, 9 months ago (2015-03-11 18:46:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/998003002/1
5 years, 9 months ago (2015-03-11 18:47:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 20:03:12 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 20:03:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc6b8fea5a3ed8cf617444263d99478c054fb0d9
Cr-Commit-Position: refs/heads/master@{#320132}

Powered by Google App Engine
This is Rietveld 408576698