Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 997983004: [turbofan] Support lazy deopt for truncating store to a typed array. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Support lazy deopt for truncating store to a typed array. The change introduces a second frame state (for the state before the operation) for the StoreProperty nodes. If the store writes into a typed array, the frame state is used for lazy deopt from the to-number conversion that is performed by the store. BUG=v8:3963 LOG=n R=bmeurer@chromium.org Committed: https://crrev.com/0cde253c9efc0b0a362ea8c1a52fe408aa2a142c Cr-Commit-Position: refs/heads/master@{#27285}

Patch Set 1 #

Patch Set 2 : No frame state for stores to variables #

Patch Set 3 : Tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -14 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 7 chunks +35 lines, -4 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/truncating-store-deopt.js View 1 chunk +28 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-18 16:30:12 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-19 05:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997983004/40001
5 years, 9 months ago (2015-03-19 05:15:13 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 05:46:28 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 05:46:40 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0cde253c9efc0b0a362ea8c1a52fe408aa2a142c
Cr-Commit-Position: refs/heads/master@{#27285}

Powered by Google App Engine
This is Rietveld 408576698