Add IsAlternativeServiceBroken(), remove is_broken.

net/http/http_server_properties_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_server_properties_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/containers/hash_tables.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "net/base/host_port_pair.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 class ListValue;
 }
 
 namespace net {
 
 const int kMaxSupportsSpdyServerHosts = 500;
 
+class HttpServerPropertiesImplPeer {
+ public:
+  static void AddBrokenAlternativeServiceWithExpirationTime(
+      HttpServerPropertiesImpl& impl,
+      AlternativeService alternative_service,
+      base::TimeTicks when) {
+    impl.broken_alternative_services_.insert(
+        std::make_pair(alternative_service, when));
+    ++impl.recently_broken_alternative_services_[alternative_service];
+  }
+
+  static void ExpireBrokenAlternateProtocolMappings(
+      HttpServerPropertiesImpl& impl) {
+    impl.ExpireBrokenAlternateProtocolMappings();
+  }
+};
+
 namespace {
 
 class HttpServerPropertiesImplTest : public testing::Test {
  protected:
   bool HasAlternateProtocol(const HostPortPair& server) {
     const AlternateProtocolInfo alternate = impl_.GetAlternateProtocol(server);
     return alternate.protocol != UNINITIALIZED_ALTERNATE_PROTOCOL;
   }
 
   HttpServerPropertiesImpl impl_;
@@ skipping 247 matching lines @@
   impl_.InitializeAlternateProtocolServers(&alternate_protocol_map);
 
   // Verify test_host_port_pair3 is the MRU server.
   const AlternateProtocolMap& map = impl_.alternate_protocol_map();
   AlternateProtocolMap::const_iterator it = map.begin();
   EXPECT_TRUE(it->first.Equals(test_host_port_pair3));
   EXPECT_EQ(1234, it->second.port);
   EXPECT_EQ(NPN_SPDY_3, it->second.protocol);
 
   ASSERT_TRUE(HasAlternateProtocol(test_host_port_pair1));
-  ASSERT_TRUE(HasAlternateProtocol(test_host_port_pair2));
-  alternate = impl_.GetAlternateProtocol(test_host_port_pair1);
-  EXPECT_TRUE(alternate.is_broken);
+  const AlternativeService alternative_service(
+      NPN_SPDY_3, test_host_port_pair1.host(), 443);
+  EXPECT_TRUE(impl_.IsAlternativeServiceBroken(alternative_service));
   alternate = impl_.GetAlternateProtocol(test_host_port_pair2);
   EXPECT_EQ(123, alternate.port);
   EXPECT_EQ(NPN_SPDY_3, alternate.protocol);
 }
 
 TEST_F(AlternateProtocolServerPropertiesTest, MRUOfGetAlternateProtocol) {
   HostPortPair test_host_port_pair1("foo1", 80);
   impl_.SetAlternateProtocol(test_host_port_pair1, 443, NPN_SPDY_3, 1.0);
   HostPortPair test_host_port_pair2("foo2", 80);
   impl_.SetAlternateProtocol(test_host_port_pair2, 1234, NPN_SPDY_3, 1.0);
@@ skipping 13 matching lines @@
   EXPECT_TRUE(it->first.Equals(test_host_port_pair1));
   EXPECT_EQ(443, it->second.port);
   EXPECT_EQ(NPN_SPDY_3, it->second.protocol);
 }
 
 TEST_F(AlternateProtocolServerPropertiesTest, SetBroken) {
   HostPortPair test_host_port_pair("foo", 80);
   impl_.SetAlternateProtocol(test_host_port_pair, 443, NPN_SPDY_3, 1.0);
   impl_.SetBrokenAlternateProtocol(test_host_port_pair);
   ASSERT_TRUE(HasAlternateProtocol(test_host_port_pair));
-  AlternateProtocolInfo alternate =
-      impl_.GetAlternateProtocol(test_host_port_pair);
-  EXPECT_TRUE(alternate.is_broken);
+  const AlternativeService alternative_service(NPN_SPDY_3,
+                                               test_host_port_pair.host(), 443);
+  EXPECT_TRUE(impl_.IsAlternativeServiceBroken(alternative_service));
 
   impl_.SetAlternateProtocol(test_host_port_pair, 1234, NPN_SPDY_3, 1.0);
-  alternate = impl_.GetAlternateProtocol(test_host_port_pair);
-  EXPECT_TRUE(alternate.is_broken) << "Second attempt should be ignored.";
+  EXPECT_TRUE(impl_.IsAlternativeServiceBroken(alternative_service));
+  const AlternateProtocolInfo alternate =
+      impl_.GetAlternateProtocol(test_host_port_pair);
+  EXPECT_EQ(1234, alternate.port);
 }
 
 TEST_F(AlternateProtocolServerPropertiesTest, ClearBroken) {
   HostPortPair test_host_port_pair("foo", 80);
   impl_.SetAlternateProtocol(test_host_port_pair, 443, NPN_SPDY_3, 1.0);
   impl_.SetBrokenAlternateProtocol(test_host_port_pair);
   ASSERT_TRUE(HasAlternateProtocol(test_host_port_pair));
-  AlternateProtocolInfo alternate =
-      impl_.GetAlternateProtocol(test_host_port_pair);
-  EXPECT_TRUE(alternate.is_broken);
+  const AlternativeService alternative_service(NPN_SPDY_3,
+                                               test_host_port_pair.host(), 443);
+  EXPECT_TRUE(impl_.IsAlternativeServiceBroken(alternative_service));
   impl_.ClearAlternateProtocol(test_host_port_pair);
-  EXPECT_FALSE(HasAlternateProtocol(test_host_port_pair));
+  EXPECT_FALSE(impl_.IsAlternativeServiceBroken(alternative_service));
 }
 
 TEST_F(AlternateProtocolServerPropertiesTest, Forced) {
   // Test forced alternate protocols.
 
   AlternateProtocolInfo default_protocol(1234, NPN_SPDY_3, 1);
   HttpServerPropertiesImpl::ForceAlternateProtocol(default_protocol);
 
   // Verify the forced protocol.
   HostPortPair test_host_port_pair("foo", 80);
@@ skipping 93 matching lines @@
   AlternateProtocolInfo canonical_protocol(1234, QUIC, 1);
 
   impl_.SetAlternateProtocol(canonical_port_pair, canonical_protocol.port,
                              canonical_protocol.protocol,
                              canonical_protocol.probability);
 
   impl_.SetBrokenAlternateProtocol(canonical_port_pair);
   EXPECT_FALSE(HasAlternateProtocol(test_host_port_pair));
 }
 
-TEST_F(AlternateProtocolServerPropertiesTest, CanonicalBroken2) {
-  HostPortPair test_host_port_pair("foo.c.youtube.com", 80);
-  HostPortPair canonical_port_pair("bar.c.youtube.com", 80);
-
-  AlternateProtocolInfo canonical_protocol(1234, QUIC, 1);
-
-  impl_.SetAlternateProtocol(canonical_port_pair, canonical_protocol.port,
-                             canonical_protocol.protocol,
-                             canonical_protocol.probability);
-
-  impl_.SetBrokenAlternateProtocol(test_host_port_pair);
-  AlternateProtocolInfo alternate =
-      impl_.GetAlternateProtocol(test_host_port_pair);
-  EXPECT_TRUE(alternate.is_broken);
-}
-
 TEST_F(AlternateProtocolServerPropertiesTest, ClearWithCanonical) {
   HostPortPair test_host_port_pair("foo.c.youtube.com", 80);
   HostPortPair canonical_port_pair("bar.c.youtube.com", 80);
 
   AlternateProtocolInfo canonical_protocol(1234, QUIC, 1);
 
   impl_.SetAlternateProtocol(canonical_port_pair, canonical_protocol.port,
                              canonical_protocol.protocol,
                              canonical_protocol.probability);
 
   impl_.Clear();
   EXPECT_FALSE(HasAlternateProtocol(test_host_port_pair));
 }
 
+TEST_F(AlternateProtocolServerPropertiesTest,
+       ExpireBrokenAlternateProtocolMappings) {
+  HostPortPair host_port_pair("foo", 443);
+  AlternativeService alternative_service(QUIC, "foo", 443);
+  impl_.SetAlternateProtocol(host_port_pair, 443, QUIC, 1.0);
+  EXPECT_TRUE(HasAlternateProtocol(host_port_pair));
+  EXPECT_FALSE(impl_.IsAlternativeServiceBroken(alternative_service));
+  EXPECT_FALSE(impl_.WasAlternateProtocolRecentlyBroken(host_port_pair));
+
+  base::TimeTicks past =
+      base::TimeTicks::Now() - base::TimeDelta::FromSeconds(42);
+  HttpServerPropertiesImplPeer::AddBrokenAlternativeServiceWithExpirationTime(
+      impl_, alternative_service, past);
+  EXPECT_TRUE(impl_.IsAlternativeServiceBroken(alternative_service));
+  EXPECT_TRUE(impl_.WasAlternateProtocolRecentlyBroken(host_port_pair));
+
+  HttpServerPropertiesImplPeer::ExpireBrokenAlternateProtocolMappings(impl_);
+  EXPECT_FALSE(impl_.IsAlternativeServiceBroken(alternative_service));
+  // TODO(bnc): Test WasAlternateProtocolRecentlyBroken once it's changed to
+  // take AlternativeService as argument.
+}
+
 typedef HttpServerPropertiesImplTest SpdySettingsServerPropertiesTest;
 
 TEST_F(SpdySettingsServerPropertiesTest, Initialize) {
   HostPortPair spdy_server_google("www.google.com", 443);
 
   // Check by initializing empty spdy settings.
   SpdySettingsMap spdy_settings_map(SpdySettingsMap::NO_AUTO_EVICT);
   impl_.InitializeSpdySettingsServers(&spdy_settings_map);
   EXPECT_TRUE(impl_.GetSpdySettings(spdy_server_google).empty());
 
@@ skipping 251 matching lines @@
   EXPECT_EQ(100, stats2->bandwidth_estimate.ToBitsPerSecond());
 
   impl_.Clear();
   const ServerNetworkStats* stats3 = impl_.GetServerNetworkStats(foo_server);
   EXPECT_EQ(NULL, stats3);
 }
 
 }  // namespace
 
 }  // namespace net