Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 997933003: Re-arranged intrinsic macros a bit. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-arranged intrinsic macros a bit. Outside of runtime.h, only the distinction between intrinsics returning pairs and those returning pairs is really meaningful, not the internal traditional partitioning of them. BUG=v8:3947 LOG=n Committed: https://crrev.com/a69cfac1828fb9020f52a6fc90a1ccc74bb76a88 Cr-Commit-Position: refs/heads/master@{#27137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -31 lines) Patch
M src/runtime/runtime.h View 3 chunks +17 lines, -21 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
Hopefully the last CL for this issue... :-)
5 years, 9 months ago (2015-03-11 14:57:50 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-11 15:05:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997933003/1
5 years, 9 months ago (2015-03-11 15:12:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 15:18:49 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 15:19:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a69cfac1828fb9020f52a6fc90a1ccc74bb76a88
Cr-Commit-Position: refs/heads/master@{#27137}

Powered by Google App Engine
This is Rietveld 408576698