Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
997923002:
fix for valgrind preAbandonGpuContext (Closed)
|
Created:
5 years, 9 months ago by joshua.litt Modified:
5 years, 9 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
Descriptionfix for valgrind preAbandonGpuContext
NOTREECHECKS=true
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/d5b98404ece3b1d29bc47f75dec58430d16e39e5
Patch Set 1 #Patch Set 2 : fix for valgrind preabandon #
Total comments: 1
Patch Set 3 : fix for valgrind leak #
Messages
Total messages: 23 (11 generated)
joshualitt@google.com changed reviewers: + joshualitt@google.com, robertphillips@google.com
A simple change to fix the valgrind preabandon step by initializing a variable and making sure to free some memory.
joshualitt@google.com changed reviewers: + mtklein@google.com
lgtm + nit (that isn't really yours) https://codereview.chromium.org/997923002/diff/20001/src/effects/SkBlurMaskFi... File src/effects/SkBlurMaskFilter.cpp (right): https://codereview.chromium.org/997923002/diff/20001/src/effects/SkBlurMaskFi... src/effects/SkBlurMaskFilter.cpp:956: blurredMask ?
If Robert's happy, please do land this when ready. I added NOTREECHECKS=true for you.
The CQ bit was checked by joshualitt@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/997923002/#ps40001 (title: "fix for valgrind leak")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997923002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 997923002-40001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com') Presubmit checks took 3.5s to calculate.
joshualitt@google.com changed reviewers: + reed@google.com
Adding Reed for a lgtm from required approver.
The CQ bit was checked by mtklein@google.com
joshualitt@google.com changed reviewers: + bsalomon@google.com
joshualitt@google.com changed reviewers: + bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997923002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 997923002-40001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
On 2015/03/11 15:47:29, I haz the power (commit-bot) wrote: > Presubmit check for 997923002-40001 failed and returned exit status 1. > > Running presubmit commit checks ... > > ** Presubmit ERRORS ** > Since the CL is editing public API, you must have an LGTM from one of: > (mailto:, mailto:, mailto:, > mailto:, mailto:, mailto:) lgtm
On 2015/03/11 15:47:29, I haz the power (commit-bot) wrote: > Presubmit check for 997923002-40001 failed and returned exit status 1. > > Running presubmit commit checks ... > > ** Presubmit ERRORS ** > Since the CL is editing public API, you must have an LGTM from one of: > (mailto:, mailto:, mailto:, > mailto:, mailto:, mailto:) lgtm
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997923002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/d5b98404ece3b1d29bc47f75dec58430d16e39e5 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
