Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 997913002: Fix debugger's overdraw color filter (Closed)

Created:
5 years, 9 months ago by robertphillips
Modified:
5 years, 9 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix debugger's overdraw color filter The colors seen in the overdraw color filter are not guaranteed to remain the colors from its own table. Looping through the table to find the old overdraw level is error prone and expensive. Committed: https://skia.googlesource.com/skia/+/6ba791f66128ebbe401978103baf7b5ec0ac98cd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Patch Set 3 : SK_ARRAY_COUNT (again) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/utils/debugger/SkDebugCanvas.cpp View 1 2 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
5 years, 9 months ago (2015-03-11 13:46:05 UTC) #2
f(malita)
lgtm https://codereview.chromium.org/997913002/diff/1/src/utils/debugger/SkDebugCanvas.cpp File src/utils/debugger/SkDebugCanvas.cpp (right): https://codereview.chromium.org/997913002/diff/1/src/utils/debugger/SkDebugCanvas.cpp#newcode94 src/utils/debugger/SkDebugCanvas.cpp:94: // This table encodes the color progression of ...
5 years, 9 months ago (2015-03-11 13:53:13 UTC) #3
robertphillips
https://codereview.chromium.org/997913002/diff/1/src/utils/debugger/SkDebugCanvas.cpp File src/utils/debugger/SkDebugCanvas.cpp (right): https://codereview.chromium.org/997913002/diff/1/src/utils/debugger/SkDebugCanvas.cpp#newcode94 src/utils/debugger/SkDebugCanvas.cpp:94: // This table encodes the color progression of the ...
5 years, 9 months ago (2015-03-11 14:10:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997913002/20001
5 years, 9 months ago (2015-03-11 14:10:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997913002/40001
5 years, 9 months ago (2015-03-11 15:12:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997913002/40001
5 years, 9 months ago (2015-03-11 15:21:16 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 18:18:04 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6ba791f66128ebbe401978103baf7b5ec0ac98cd

Powered by Google App Engine
This is Rietveld 408576698