Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 997873004: Terminal: Add support for (and "fix") backspace. (Closed)

Created:
5 years, 9 months ago by viettrungluu
Modified:
5 years, 9 months ago
Reviewers:
Elliot Glaysher, ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Terminal: Add support for (and "fix") backspace. Also: * Fix consecutive spaces (don't collapse them). * Add support for ^L. Still doesn't work: * Totally blank lines. (I know why, but I don't know why I can't seem to fix it.) R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8b754a508f50c6b4604ccce95c7b0d3fe960f35b

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased/updated #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M sky/examples/terminal/terminal.sky View 4 chunks +60 lines, -9 lines 1 comment Download
M sky/examples/terminal/terminal_file_impl.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
5 years, 9 months ago (2015-03-11 23:27:48 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/997873004/diff/1/sky/examples/terminal/terminal.sky File sky/examples/terminal/terminal.sky (right): https://codereview.chromium.org/997873004/diff/1/sky/examples/terminal/terminal.sky#newcode97 sky/examples/terminal/terminal.sky:97: _control.lastChild.textContent = oldText.substring(0, oldText.length - 1); Looking forward ...
5 years, 9 months ago (2015-03-11 23:33:49 UTC) #2
viettrungluu
Committed patchset #2 (id:20001) manually as 8b754a508f50c6b4604ccce95c7b0d3fe960f35b (presubmit successful).
5 years, 9 months ago (2015-03-11 23:54:21 UTC) #3
ojan
5 years, 9 months ago (2015-03-12 20:11:48 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/997873004/diff/20001/sky/examples/terminal/te...
File sky/examples/terminal/terminal.sky (right):

https://codereview.chromium.org/997873004/diff/20001/sky/examples/terminal/te...
sky/examples/terminal/terminal.sky:66: void _handleKeyDown(KeyboardEvent event)
{
FWIW, you're better off just not using keypress. Use keydown for everything. We
need to remove keypress from the platform.

As for the contentedtiable thing, it appears we've broken tabindex (the standard
way of making something focusable on the web.

Powered by Google App Engine
This is Rietveld 408576698