Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 997863003: Remove superfluous ThreadLocalTop::catcher field. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove superfluous ThreadLocalTop::catcher field. The external v8::TryCatch handler was computed eagerly and kept in intact. This changes it to be computed lazily for simplicity and readability of the code. R=bmeurer@chromium.org Committed: https://crrev.com/61e4b6028b094940493b0332c7c107fa18ef2573 Cr-Commit-Position: refs/heads/master@{#27132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M src/isolate.h View 4 chunks +5 lines, -13 lines 0 comments Download
M src/isolate.cc View 6 chunks +8 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-11 12:51:28 UTC) #1
Benedikt Meurer
Amazing...how many engineering hours went into creating and maintaining this painful piece of code? LGTM
5 years, 9 months ago (2015-03-11 12:53:05 UTC) #2
Michael Starzinger
The removal of superfluous will continue until readability improves.
5 years, 9 months ago (2015-03-11 12:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997863003/1
5 years, 9 months ago (2015-03-11 13:35:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 13:36:12 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 13:36:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61e4b6028b094940493b0332c7c107fa18ef2573
Cr-Commit-Position: refs/heads/master@{#27132}

Powered by Google App Engine
This is Rietveld 408576698