Allow depfile to depend on a Stamp file instead of the default first input.

grit/tool/build_unittest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 '''Unit tests for the 'grit build' tool.
 '''
 
 import codecs
 import os
@@ skipping 283 matching lines @@
     second_mtime = os.stat(header).st_mtime
 
     os.utime(header, (UNCHANGED, UNCHANGED))
     builder.Run(DummyOpts(), ['-o', output_dir, '--write-only-new', '1'])
     self.failUnless(os.path.exists(header))
     third_mtime = os.stat(header).st_mtime
 
     self.assertTrue(abs(second_mtime - UNCHANGED) > 5)
     self.assertTrue(abs(third_mtime - UNCHANGED) < 5)
 
+  def testGenerateDepFileWithDependOnStamp(self):
+    output_dir = tempfile.mkdtemp()
+    builder = build.RcBuilder()
+    class DummyOpts(object):
+      def __init__(self):
+        self.input = util.PathFromRoot('grit/testdata/substitute.grd')
+        self.verbose = False
+        self.extra_verbose = False
+    expected_dep_file_name = 'substitute.grd.d'
+    expected_stamp_file_name = expected_dep_file_name + '.stamp'
+    expected_dep_file = os.path.join(output_dir, expected_dep_file_name)
+    expected_stamp_file = os.path.join(output_dir, expected_stamp_file_name)
+    if os.path.isfile(expected_stamp_file):
+      os.remove(expected_stamp_file)
+    builder.Run(DummyOpts(), ['-o', output_dir,
+                              '--depdir', output_dir,
+                              '--depfile', expected_dep_file,
+                              '--depend-on-stamp'])
+    self.failUnless(os.path.isfile(expected_stamp_file))
+    first_mtime = os.stat(expected_stamp_file).st_mtime
+    builder.Run(DummyOpts(), ['-o', output_dir,
+                              '--depdir', output_dir,
+                              '--depfile', expected_dep_file,
+                              '--depend-on-stamp'])
+    self.failUnless(os.path.isfile(expected_stamp_file))
+    second_mtime = os.stat(expected_stamp_file).st_mtime
+    self.assertTrue(second_mtime > first_mtime)

[Nico, 2015/03/23 18:59:35]

this fails for me:

======================================================================
FAIL: testGenerateDepFileWithDependOnStamp
(grit.tool.build_unittest.BuildUnittest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/MacintoshHD2/src/grit-i18n/grit/tool/build_unittest.py", line
330, in testGenerateDepFileWithDependOnStamp
    self.assertTrue(second_mtime > first_mtime)
AssertionError: False is not true


You probably can't assume that 2s (stat resolution on win) pass when running
this twice?

Here's a hack you can use: set the mtime before rebuilding to something very
old, and then check that it has changed (example:
https://codereview.chromium.org/757213003/diff/60001/grit/tool/build_unittest.py
)

[knn, 2015/03/23 19:28:14]

Oh I see :(
Thanks!

+
+    self.failUnless(os.path.isfile(expected_dep_file))
+    with open(expected_dep_file) as f:
+      line = f.readline()
+      (dep_output_file, deps_string) = line.split(': ')
+      deps = deps_string.split(' ')
+
+      self.failUnlessEqual(expected_stamp_file_name, dep_output_file)
+      self.failUnlessEqual(1, len(deps))
+      self.failUnlessEqual(deps[0],
+          util.PathFromRoot('grit/testdata/substitute.xmb'))
+
 
 if __name__ == '__main__':
   unittest.main()