[Contextual Search] Prevents promo from being displayed incorrectly.

[Contextual Search] Prevents promo from being displayed incorrectly.

This a preventive CL. It does not actually fix the problem, which
happens rarely, but instead, it prevents the promo from being
displayed incorrectly.

BUG=465933
Committed: https://crrev.com/46a8b676dd2a3b454fd3e6b92a6ea1da99bed796
Cr-Commit-Position: refs/heads/master@{#320169}

[pedro (no code reviews), 2015-03-10 23:22:54]

pedrosimonetti@chromium.org changed reviewers:
+ donnd@chromium.org

[pedro (no code reviews), 2015-03-10 23:23:56]

Hey Donn, please take a look at this change, this is the native side of the
change. A downstream CL is also needed, and I'll upload it right now.

[Donn Denman, 2015-03-10 23:29:02]

lgtm

https://codereview.chromium.org/997733002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/997733002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:519:
* Gets the height of the promo content, or -1 if height could not be calculated.
Nit: change "could not be" to "has not been"?

[pedro (no code reviews), 2015-03-10 23:40:14]

https://codereview.chromium.org/997733002/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/997733002/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:519:
* Gets the height of the promo content, or -1 if height could not be calculated.
On 2015/03/10 23:29:01, Donn Denman wrote:
> Nit: change "could not be" to "has not been"?

Done.

[pedro (no code reviews), 2015-03-10 23:40:26]

pedrosimonetti@chromium.org changed reviewers:
+ dtrainor@chromium.org

[pedro (no code reviews), 2015-03-10 23:40:46]

Hey David, could you please take a look at this change?

[David Trainor- moved to gerrit, 2015-03-11 21:36:56]

lgtm

[pedro (no code reviews), 2015-03-11 21:52:11]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2015-03-11 21:52:11]

The patchset sent to the CQ was uploaded after l-g-t-m from donnd@chromium.org
Link to the patchset: https://codereview.chromium.org/997733002/#ps20001 (title:
"Addressing Donn's comment")

[commit-bot: I haz the power, 2015-03-11 21:53:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997733002/20001

[commit-bot: I haz the power, 2015-03-11 22:26:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-11 22:27:11]

Patchset 2 (id:??) landed as
https://crrev.com/46a8b676dd2a3b454fd3e6b92a6ea1da99bed796
Cr-Commit-Position: refs/heads/master@{#320169}