chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java - Issue 997713004: Redo Autofill wallet preferences on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java

Issue 997713004: Redo Autofill wallet preferences on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/TextAndButtonPreference.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java

index 15ea95848872429559aa2a487e0b960792eba2ce..895b42d46729fb8ec0a05b5be6c416cef833ad96 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java

@@ -33,8 +33,8 @@ import java.util.Locale;

public class AutofillCreditCardEditor extends Fragment implements OnItemSelectedListener,

TextWatcher {

- // GUID of the profile we are editing.

- // May be the empty string if creating a new profile.

+ // GUID of the card profile we are editing.

+ // May be the empty string if creating a new card.

private String mGUID;

private FloatLabelLayout mNameLabel;

@@ -190,12 +190,9 @@ public class AutofillCreditCardEditor extends Fragment implements OnItemSelected

private void saveCreditCard() {

// Remove all spaces in editText.

String cardNumber = mNumberText.getText().toString().replaceAll("\\s+", "");

- CreditCard card = new CreditCard(

- mGUID,

- AutofillPreferences.SETTINGS_ORIGIN,

- mNameText.getText().toString().trim(),

- cardNumber,

- cardNumber, // obfuscated number, it will be obfuscated by native code.

+ CreditCard card = new CreditCard(mGUID, AutofillPreferences.SETTINGS_ORIGIN,

+ true /* isLocal */, false /* isCached */, mNameText.getText().toString().trim(),

+ cardNumber, "" /* obfuscatedNumber */,

String.valueOf(mExpirationMonth.getSelectedItemPosition() + 1),

(String) mExpirationYear.getSelectedItem());