Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2622)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java

Issue 997713004: Redo Autofill wallet preferences on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: newt review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
index 15ea95848872429559aa2a487e0b960792eba2ce..0de5d983775000a689249327fda790a8ec13b9b2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
@@ -33,8 +33,8 @@ import java.util.Locale;
*/
public class AutofillCreditCardEditor extends Fragment implements OnItemSelectedListener,
TextWatcher {
- // GUID of the profile we are editing.
- // May be the empty string if creating a new profile.
+ // GUID of the card profile we are editing.
+ // May be the empty string if creating a new card.
private String mGUID;
private FloatLabelLayout mNameLabel;
@@ -190,12 +190,9 @@ public class AutofillCreditCardEditor extends Fragment implements OnItemSelected
private void saveCreditCard() {
// Remove all spaces in editText.
String cardNumber = mNumberText.getText().toString().replaceAll("\\s+", "");
- CreditCard card = new CreditCard(
- mGUID,
- AutofillPreferences.SETTINGS_ORIGIN,
- mNameText.getText().toString().trim(),
- cardNumber,
- cardNumber, // obfuscated number, it will be obfuscated by native code.
+ CreditCard card = new CreditCard(mGUID, AutofillPreferences.SETTINGS_ORIGIN,
+ true /* isLocal */, false /* isCached */, mNameText.getText().toString().trim(),
+ cardNumber, new String() /* obfuscatedNumber */,
newt (away) 2015/03/19 01:41:43 You could pass "" instead of new String() to avoid
Evan Stade 2015/03/20 00:14:57 Done.
String.valueOf(mExpirationMonth.getSelectedItemPosition() + 1),
(String) mExpirationYear.getSelectedItem());

Powered by Google App Engine
This is Rietveld 408576698