Redo Autofill wallet preferences on Android.

chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java
new file mode 100644
index 0000000000000000000000000000000000000000..98f0d9fc77f5591f4948ba4349040ac33acf600d
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerCardPreferences.java
@@ -0,0 +1,73 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.autofill;
+
+import android.os.Bundle;
+import android.preference.Preference;
+import android.preference.Preference.OnPreferenceClickListener;
+import android.preference.PreferenceFragment;
+
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.autofill.PersonalDataManager;
+import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard;
+import org.chromium.chrome.browser.preferences.Preferences;
+
+/**
+ * Fragment for settings page that allows user to view and edit a single server-provided credit
+ * card.
+ */
+public class AutofillServerCardPreferences
+        extends PreferenceFragment implements OnPreferenceClickListener {
+    private String mGUID;
+
+    private static final String PREF_SERVER_CARD_DESCRIPTION = "server_card_description";
+    private static final String PREF_SERVER_CARD_EDIT_LINK = "server_card_edit_link";
+    private static final String PREF_SERVER_CARD_LOCAL_COPY = "server_card_local_copy_button";
+
+    @Override
+    public void onCreate(Bundle savedState) {
+        super.onCreate(savedState);
+        addPreferencesFromResource(R.xml.autofill_server_card_preferences);
+        getActivity().setTitle(R.string.autofill_edit_credit_card);
+
+        // We know which card to display based on the GUID stuffed in
+        // our extras by AutofillPreferences.
+        Bundle extras = getArguments();
+        if (extras != null) {
+            mGUID = extras.getString(AutofillPreferences.AUTOFILL_GUID);
+        }
+        assert mGUID != null;
+        CreditCard card = PersonalDataManager.getInstance().getCreditCard(mGUID);
+        assert !card.getIsLocal();
+
+        Preference cardDescription = findPreference(PREF_SERVER_CARD_DESCRIPTION);
+        cardDescription.setTitle(card.getObfuscatedNumber());
+        cardDescription.setSummary(card.getMonth() + "/" + card.getYear());

[newt (away), 2015/03/18 04:31:45]

You should use Android's DateUtils or a similar class to format this date. For
one thing, string concatenation will convert integers to 0123456789, but some
languages use different numerals. I'd wouldn't be surprised if the date
separator varies by locale as well.

[Evan Stade, 2015/03/19 00:24:22]

I have never heard that other locales don't use Arabic numerals --- can you give
an example? I looked at DateUtils and SimpleDateFormat and neither seemed like
they had something useful. getBestDateTimePattern only has examples for month +
day varying by locale.

I have actually looked into this before because it's relevant to how Chrome
fills in the webpage or shows expiration dates in the suggestion dropdown. I
couldn't find any evidence that an expiration date such as "12/2016" was invalid
in some locale.
yea there is a string we can use here --- done. I'm still skeptical/curious if
it's going to be translated to something other than "/".

[newt (away), 2015/03/19 01:41:42]

http://en.wikipedia.org/wiki/Eastern_Arabic_numerals

Also, some less common languages: Bengali, Marathi, Nepalese

Arabic: ١٨/‏٣
Bengali: ১৮/৩
Marathi: १८/३
Nepali: ०३-१८
I tried formatting dates for all the available locales on my device. There are
lots of different separators used:

    Filipino: 3/18
     Faroese: 03-18
      French: 18/3
       Irish: 18/03
    Galician: 18-3
Swiss German: 18.3.
    Gujarati: 18/3
       Gusii: 3/18
        Manx: 03-18
       Hausa: 3/18
    Hawaiian: 18/3
      Hebrew: 18/3
       Hindi: 18/3
    Croatian: 18. 3.
   Hungarian: 3. 18.
    Armenian: 18.03
  Indonesian: 18/3
        Igbo: 3/18

I was using DateUtils.formatDateTime(context, System.currentTimeMillis(),
DateUtils.FORMAT_SHOW_DATE | DateUtils.FORMAT_NUMERIC_DATE). You should be able
to use that or maybe SimpleDateFormat.

[Evan Stade, 2015/03/20 00:14:56]

getMonth and getYear are strings so the responsibility of converting from number
to locale-aware string is upstream from here.
This example is month and day, not month and year. The order of month/day
differs by locale, I still think the order of month/year is the same everywhere
(except in RTL languages of course, but that doesn't affect the order of
characters in the string).

I still believe we want mm(separator)yyyy everywhere. It's what the rest of
Chrome does, which is not to say it's right, but I've never seen a bug filed
about this.

[newt (away), 2015/03/20 00:53:45]

Gotcha.
Ok, I'll buy that.

+
+        findPreference(PREF_SERVER_CARD_EDIT_LINK).setOnPreferenceClickListener(this);
+
+        Preference clearLocalCopy = findPreference(PREF_SERVER_CARD_LOCAL_COPY);
+        if (!card.getIsCached()) {
+            getPreferenceScreen().removePreference(clearLocalCopy);
+        } else {
+            clearLocalCopy.setOnPreferenceClickListener(this);
+        }
+    }
+
+    @Override
+    public boolean onPreferenceClick(Preference preference) {
+        if (preference.getKey().equals(PREF_SERVER_CARD_EDIT_LINK)) {
+            ((Preferences) preference.getContext())
+                    .showUrl(R.string.autofill_edit_credit_card,
+                             R.string.autofill_manage_wallet_cards_url);
+        } else {
+            assert preference.getKey().equals(PREF_SERVER_CARD_LOCAL_COPY);
+            PersonalDataManager.getInstance().clearUnmaskedCache(mGUID);
+            // It's no longer cached locally. Hide the clear button.
+            getPreferenceScreen().removePreference(preference);
+        }
+        return true;
+    }
+}