chrome/android/java/res/layout/autofill_server_card_clear_copy_button.xml - Issue 997713004: Redo Autofill wallet preferences on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/autofill_server_card_clear_copy_button.xml

Issue 997713004: Redo Autofill wallet preferences on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: typo fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <!-- Layout for button that permits user to clear the local copy of a card. -->

	7 <org.chromium.chrome.browser.widget.ButtonCompat

	8 xmlns:android="http://schemas.android.com/apk/res/android"

	9 xmlns:chrome="http://schemas.android.com/apk/res-auto"

	10 android:id="@+id/button_preference"

	11 android:layout_height="wrap_content"

	12 android:layout_width="wrap_content"

	13 android:minHeight="40dp"
	newt (away) 2015/03/18 04:31:44 By default, buttons have a minHeight of 36dp. We u By default, buttons have a minHeight of 36dp. We use this in other parts of settings, so it'd be nice not to deviate here. Evan Stade 2015/03/19 00:24:22 This is actually copied from preference_button.xml Show quoted text On 2015/03/18 04:31:44, newt wrote: > By default, buttons have a minHeight of 36dp. We use this in other parts of > settings, so it'd be nice not to deviate here. This is actually copied from preference_button.xml. As you can see, I forgot to delete android:id="@+id/button_preference" (or I might should leave it to use it in findViewById as you suggetsed). The reason I didn't just reuse preference_button.xml is because I couldn't figure out how to set the text in an elegant way (also the extra LinearLayout wrapper was not needed). newt (away) 2015/03/19 01:41:42 Ah, my bad. Didn't realize we override the height Show quoted text On 2015/03/19 00:24:22, Evan Stade wrote: > On 2015/03/18 04:31:44, newt wrote: > > By default, buttons have a minHeight of 36dp. We use this in other parts of > > settings, so it'd be nice not to deviate here. > > This is actually copied from preference_button.xml. As you can see, I forgot to > delete android:id="@+id/button_preference" (or I might should leave it to use it > in findViewById as you suggetsed). > > The reason I didn't just reuse preference_button.xml is because I couldn't > figure out how to set the text in an elegant way (also the extra LinearLayout > wrapper was not needed). Ah, my bad. Didn't realize we override the height in preference_button.xml too
	14 android:textColor="#fff"

	15 android:text="@string/autofill_clear_local_copy_button"

	16 chrome:buttonColor="@color/pref_accent_color" />

OLD	NEW