Exit cleanly for the SRPC "log" requests instead of generating crash reports.

src/trusted/service_runtime/nacl_secure_service.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/trusted/service_runtime/nacl_secure_service.h"
 
 #include <string.h>
 
@@ skipping 239 matching lines @@
 static void NaClSecureServiceLogRpc(
     struct NaClSrpcRpc      *rpc,
     struct NaClSrpcArg      **in_args,
     struct NaClSrpcArg      **out_args,
     struct NaClSrpcClosure  *done_cls) {
   int   severity = in_args[0]->u.ival;
   char  *msg = in_args[1]->arrays.str;
   UNREFERENCED_PARAMETER(out_args);
 
   NaClLog(5, "NaClSecureChannelLogRpc\n");
+  if (LOG_FATAL == severity) {
+    /*
+     * Do not actually abort due to LOG_FATAL. SRPC is deprecated and the
+     * only remaining user of this Log RPC corresponds to fairly benign
+     * errors. Also, at this point the backtraces will not be terribly
+     * interesting. Therefore, avoid spamming the crash report counter
+     * for such errors and exit cleanly. Run the abort hook as well,
+     * to flush the logs.
+     */
+    NaClLog(LOG_ERROR, "%s\n", msg);
+    NaClLogRunAbortBehavior();
+    NaClExit(1);
+  }
   NaClLog(severity, "%s\n", msg);
   NaClLog(5, "NaClSecureChannelLogRpc\n");
   rpc->result = NACL_SRPC_RESULT_OK;
   (*done_cls->Run)(done_cls);
 }
 
 static void NaClSecureServiceShutdownRpc(
     struct NaClSrpcRpc      *rpc,
     struct NaClSrpcArg      **in_args,
     struct NaClSrpcArg      **out_args,
@@ skipping 18 matching lines @@
 
 struct NaClSimpleServiceVtbl const kNaClSecureServiceVtbl = {
   {
     NaClSecureServiceDtor,
   },
   NaClSecureServiceConnectionFactory,
   NaClSecureServiceAcceptConnection,
   NaClSimpleServiceAcceptAndSpawnHandler,
   NaClSecureServiceRpcHandler,
 };