Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 997673002: Disable tests that depend on function length being non configurable (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Disable tests that depend on function length being non configurable This is in preparation for v8:2833 BUG=465864 R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191661

Patch Set 1 #

Patch Set 2 : ietestcenter also tests the length property #

Patch Set 3 : webperf too #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +10 lines, -1 line 1 comment Download

Messages

Total messages: 18 (6 generated)
arv (Not doing code reviews)
PTAL
5 years, 9 months ago (2015-03-10 20:39:37 UTC) #1
adamk
lgtm
5 years, 9 months ago (2015-03-10 20:42:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997673002/1
5 years, 9 months ago (2015-03-10 20:44:25 UTC) #4
arv (Not doing code reviews)
ietestcenter also tests the length property
5 years, 9 months ago (2015-03-10 20:59:53 UTC) #6
arv (Not doing code reviews)
There are some more tests that needs to be disabled in the ietestcenter folder.
5 years, 9 months ago (2015-03-10 21:00:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997673002/20001
5 years, 9 months ago (2015-03-10 21:01:36 UTC) #10
arv (Not doing code reviews)
webperf too
5 years, 9 months ago (2015-03-10 21:34:24 UTC) #12
arv (Not doing code reviews)
Alright, all tests identified and disabled. PTAL
5 years, 9 months ago (2015-03-10 21:34:48 UTC) #13
arv (Not doing code reviews)
https://codereview.chromium.org/997673002/diff/40001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/997673002/diff/40001/LayoutTests/TestExpectations#newcode582 LayoutTests/TestExpectations:582: crbug.com/316148 crbug.com/465864 http/tests/w3c/webperf/approved/UserTiming/idlharness.html [ Pass Failure Crash ] I ...
5 years, 9 months ago (2015-03-10 21:35:51 UTC) #14
adamk
Still lgtm. don't know what to tell you about the linter.
5 years, 9 months ago (2015-03-10 22:01:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997673002/40001
5 years, 9 months ago (2015-03-10 22:04:13 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 00:43:49 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191661

Powered by Google App Engine
This is Rietveld 408576698