Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 997663002: MIPS: Remove frame pointer from StackHandler. (Closed)

Created:
5 years, 9 months ago by paul.l...
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Remove frame pointer from StackHandler. Port 36e69a916f2a88664887d2b62f0eaf8400edb182 Original commit message: This reduces the size of the StackHandler by yet another word. We no longer need to keep track of the frame pointer, as the stack walk will be able to recalculate it. BUG= Committed: https://crrev.com/0c12ff2db45b9d4d5b789c0f83af45b1c1096c6e Cr-Commit-Position: refs/heads/master@{#27123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M src/mips/macro-assembler-mips.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
paul.l...
ptal
5 years, 9 months ago (2015-03-10 20:01:46 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-10 20:05:40 UTC) #3
akos.palfi.imgtec
lgtm
5 years, 9 months ago (2015-03-10 20:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997663002/1
5 years, 9 months ago (2015-03-10 20:09:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 20:43:45 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 20:44:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c12ff2db45b9d4d5b789c0f83af45b1c1096c6e
Cr-Commit-Position: refs/heads/master@{#27123}

Powered by Google App Engine
This is Rietveld 408576698