Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 997633002: Bump en-us/ca spellcheck dictionaries used. (Closed)

Created:
5 years, 9 months ago by please use gerrit instead
Modified:
5 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bump en-us/ca spellcheck dictionaries used. Dictionaries en-US-6-1.bdic and en-CA-6-1.bdic now support typographical apostrophes and have been uploaded to the server. BUG=165079 Committed: https://crrev.com/febbefc70c3f0924239b454d54baca1a682de8ef Cr-Commit-Position: refs/heads/master@{#320390}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/common/spellcheck_common.cc View 1 chunk +4 lines, -2 lines 1 comment Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
please use gerrit instead
Rachel, PTAL.
5 years, 9 months ago (2015-03-11 20:55:54 UTC) #3
groby-ooo-7-16
Sorry - "Rachel" in a spellcheck context always sounds like "rlp" to me :) LGTM ...
5 years, 9 months ago (2015-03-12 21:08:07 UTC) #4
please use gerrit instead
On 2015/03/12 21:08:07, groby wrote: > Sorry - "Rachel" in a spellcheck context always sounds ...
5 years, 9 months ago (2015-03-12 21:16:10 UTC) #5
groby-ooo-7-16
Please do. Meanwhile, LGTM here.
5 years, 9 months ago (2015-03-12 21:20:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997633002/20001
5 years, 9 months ago (2015-03-12 21:27:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-12 22:24:53 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 22:25:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/febbefc70c3f0924239b454d54baca1a682de8ef
Cr-Commit-Position: refs/heads/master@{#320390}

Powered by Google App Engine
This is Rietveld 408576698