Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java

Issue 997623002: [Cronet] Respect user agent string from config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass user agent string directly Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
index 58c4d313f9c02a1c57599d64b8cc0b1f7055c697..ddf4011a725bf3b26f2f507f87d39dfd8747b163 100644
--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlConnectionUrlRequestFactory.java
@@ -17,10 +17,16 @@ import java.util.Map;
class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {
private final Context mContext;
+ private final String mDefaultUserAgent;
public HttpUrlConnectionUrlRequestFactory(
Context context, UrlRequestContextConfig config) {
mContext = context;
+ String userAgent = config.userAgent();
+ if (userAgent.isEmpty()) {
+ userAgent = UserAgent.from(mContext);
+ }
+ mDefaultUserAgent = userAgent;
}
@Override
@@ -36,16 +42,16 @@ class HttpUrlConnectionUrlRequestFactory extends HttpUrlRequestFactory {
@Override
public HttpUrlRequest createRequest(String url, int requestPriority,
Map<String, String> headers, HttpUrlRequestListener listener) {
- return new HttpUrlConnectionUrlRequest(mContext, url, requestPriority,
- headers, listener);
+ return new HttpUrlConnectionUrlRequest(mContext, mDefaultUserAgent, url,
+ requestPriority, headers, listener);
}
@Override
public HttpUrlRequest createRequest(String url, int requestPriority,
Map<String, String> headers, WritableByteChannel channel,
HttpUrlRequestListener listener) {
- return new HttpUrlConnectionUrlRequest(mContext, url, requestPriority,
- headers, channel, listener);
+ return new HttpUrlConnectionUrlRequest(mContext, mDefaultUserAgent, url,
+ requestPriority, headers, channel, listener);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698