Fix Settings::OpenForReadingAndWriting using O_CREAT with no mode.

client/settings.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 12 matching lines @@
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "util/numeric/in_range_cast.h"
 
 namespace crashpad {
 
 struct ALIGNAS(4) Settings::Data {
   static const uint16_t kSettingsVersion = 1;
 
+  enum Options : uint32_t {
+    kUploadsEnabled = 1 << 0,
+  };
+
   Data() : version(kSettingsVersion),
            options(0),
            last_upload_attempt_time(0),
            client_id() {}
 
-  enum Options : uint32_t {
-    kUploadsEnabled = 1 << 0,
-  };
-
   uint32_t version;
   uint32_t options;
   uint64_t last_upload_attempt_time;  // time_t
   UUID client_id;
 };
 
 Settings::Settings(const base::FilePath& file_path)
     : file_path_(file_path),
       initialized_() {
 }
@@ skipping 93 matching lines @@
 }
 
 ScopedFileHandle Settings::OpenForReading() {
   ScopedFileHandle handle(HANDLE_EINTR(open(file_path(), O_RDONLY | O_SHLOCK)));
   PLOG_IF(ERROR, !handle.is_valid()) << "open for reading";
   return handle.Pass();
 }
 
 ScopedFileHandle Settings::OpenForReadingAndWriting() {
   ScopedFileHandle handle(HANDLE_EINTR(
-      open(file_path(), O_RDWR | O_EXLOCK | O_CREAT)));
+      open(file_path(), O_RDWR | O_EXLOCK | O_CREAT, 0644)));
   PLOG_IF(ERROR, !handle.is_valid()) << "open for writing";
   return handle.Pass();
 }
 
 bool Settings::OpenAndReadSettings(Data* out_data) {
   ScopedFileHandle handle = OpenForReading();
   if (!handle.is_valid())
     return false;
 
   if (ReadSettings(handle.get(), out_data))
@@ skipping 75 matching lines @@
   uuid_t uuid;
   uuid_generate(uuid);
 
   Data settings;
   settings.client_id.InitializeFromBytes(uuid);
 
   return WriteSettings(handle, settings);
 }
 
 }  // namespace crashpad