Issue 997613002: Fix Settings::OpenForReadingAndWriting using O_CREAT with no mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 997613002: Fix Settings::OpenForReadingAndWriting using O_CREAT with no mode. (Closed)

Created:
5 years, 9 months ago by Robert Sesek

Modified:
5 years, 9 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	client/settings.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	client/settings_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Robert Sesek

5 years, 9 months ago (2015-03-10 17:52:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as
e4c8b6cc72bbd096ccaded29e2ad6554e9204a26 (presubmit successful).