Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 997513003: CpuProfiler: fix for CollectDeoptEvents test on arm (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, alph, jbramley, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: fix for CollectDeoptEvents test on arm The same idea as in https://codereview.chromium.org/984893003/ BUG=chromium:452067 LOG=n Committed: https://crrev.com/a925f3f4784f8318f69a201a6b44aa94f97e4ba3 Cr-Commit-Position: refs/heads/master@{#27114}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -41 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +25 lines, -41 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-10 12:26:44 UTC) #2
jbramley
https://codereview.chromium.org/997513003/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/997513003/diff/1/src/arm/lithium-codegen-arm.cc#newcode356 src/arm/lithium-codegen-arm.cc:356: bool need_branch = ((i + 1) != length); Because ...
5 years, 9 months ago (2015-03-10 14:24:40 UTC) #3
loislo
https://codereview.chromium.org/997513003/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/997513003/diff/1/src/arm/lithium-codegen-arm.cc#newcode356 src/arm/lithium-codegen-arm.cc:356: bool need_branch = ((i + 1) != length); On ...
5 years, 9 months ago (2015-03-10 14:30:37 UTC) #4
jbramley
lgtm
5 years, 9 months ago (2015-03-10 14:34:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997513003/20001
5 years, 9 months ago (2015-03-10 14:37:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1100)
5 years, 9 months ago (2015-03-10 14:56:24 UTC) #9
Sven Panne
lgtm
5 years, 9 months ago (2015-03-10 15:00:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997513003/20001
5 years, 9 months ago (2015-03-10 15:01:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 15:15:17 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:15:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a925f3f4784f8318f69a201a6b44aa94f97e4ba3
Cr-Commit-Position: refs/heads/master@{#27114}

Powered by Google App Engine
This is Rietveld 408576698