Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 997513002: [turbofan] Use builtin inlining mechanism for Math.floor. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use builtin inlining mechanism for Math.floor. BUG=v8:3952 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/1982186b6fb27d832fc217a0f8706912459fab15 Cr-Commit-Position: refs/heads/master@{#27098}

Patch Set 1 #

Patch Set 2 : Andreas wants to keep the typer separate from inlining. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -53 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/math.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-10 10:39:16 UTC) #1
Benedikt Meurer
Followup cleanup. PTAL
5 years, 9 months ago (2015-03-10 10:39:30 UTC) #2
Yang
On 2015/03/10 10:39:30, Benedikt Meurer wrote: > Followup cleanup. PTAL lgtm.
5 years, 9 months ago (2015-03-10 10:40:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997513002/20001
5 years, 9 months ago (2015-03-10 10:44:50 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 11:59:23 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 11:59:39 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1982186b6fb27d832fc217a0f8706912459fab15
Cr-Commit-Position: refs/heads/master@{#27098}

Powered by Google App Engine
This is Rietveld 408576698