Issue 99743004: Merge 163945 "Fix assertion failure in FormAssociatedElement::fo..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99743004: Merge 163945 "Fix assertion failure in FormAssociatedElement::fo..." (Closed)

Created:
6 years, 11 months ago by tkent

Modified:
6 years, 11 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1700/

Visibility:
Public.

Merge 163945 "Fix assertion failure in FormAssociatedElement::fo..." > Fix assertion failure in FormAssociatedElement::formRemovedFromTree. > > This is a regression by Blink r163680 [1]. > FormAssociatedElement::formRemovedFromTree can be called with > m_deletionHasBegun. We should not update the reference counter in it. > > Removing RefPtr<> for HTMLFormElement::m_pastNamesMap magically fixes the > original problem. > > This CL has no tests. I couldn't make a test which works as a layout test. > > [1] http://src.chromium.org/viewvc/blink?revision=163680&view=revision > > BUG=326854, 328456 > > Review URL: https://codereview.chromium.org/113423005 TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164445

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -3 lines)			Patch
M	Source/core/html/FormAssociatedElement.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLFormElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLFormElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r164445.